When more than one consumer type is defined, such as drupal roles and organic groups, the load fails. In LdapAuthorizationConsumerConf.class.php, the following should be changed. This is in head now for 7.x-1.x

  function __construct(&$consumer, $_new = FALSE, $_sid = NULL) {
    $this->consumer = $consumer;
    if ($_new) {
      $this->inDatabase = FALSE;
      $this->consumerType = $consumer->consumerType; //FALSE;
    }
    else {
+     $this->consumerType = $consumer->consumerType;
      $this->inDatabase = TRUE;
      $this->loadFromDb();
    }
  }

Comments

johnbarclay’s picture

johnbarclay commented
Status: Active » Fixed
dayer4b’s picture

dayer4b commented

Awesome! Thanks, I'll try this out ASAP.

johnbarclay’s picture

johnbarclay commented

part of the same issue in ldap_authorization.admin.test.inc is that the tests were showing authorization results from all consumer types at the same time, but labelling them all with a single consumer type. This is in head also.

   if ($username) {
      if (!$user = user_load_by_name($username)) {
        // if not existing user, create fake user assumed to be ldap authenticated
        $user = new stdClass();
        $user->name = $username;
        $user->ldap_test = TRUE;
        $user->ldap_authenticated = TRUE;
      }
      list($results[$username], $notifications[$username]) = ldap_authorizations_user_authorizations($user, 'test_query', $consumer_type, 'logon');
+     // remove authorizations from other consumer types
+      $results[$username] = array($consumer_type => $results[$username][$consumer_type]);
      $i++;
      if ($i == 10) {
        break;
      }

    }
dayer4b’s picture

dayer4b commented

That last update really helped. I had noticed the authorization tests problem earlier, but I didn't have time to post about it. Thanks for taking care of it. It's starting to look like my LDAP OG consumer is working properly! I just need to test it more and add a configuration parameter or two.

thanks!

johnbarclay’s picture

johnbarclay commented

Great!

Do you have any feedback on the structure of the ldap_authorization module and the consumer class? Are there additional properties/methods that you added that might be useful in the abstract class?

If you are going through the module application process, let me know and I can help speed things along by reviewing it. If you want to stick it in this project and have git access that would be fine too.

dayer4b’s picture

dayer4b commented

I think sticking it into this project might be the way to go. I'm sorry I've been incommunicado again, I was pretty sick for the last few days, and I'm also getting married this weekend. I realized that it's still not quite working properly. I'll update you when I can get it.

thanks

johnbarclay’s picture

johnbarclay commented

congrats on the marriage.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.