By dries on

We have upgraded drupal.org to use the development version of Drupal (CVS HEAD). Please report problems (such as broken links and PHP warnings) in the comments below for the site maintainers to pick up and fix. Thanks.

Comments

dries’s picture

dries commented

It would be nice to have some mod_rewrite rules to redirect external referers. See the rewrite_old_url() function in includes/common.inc for inspiration.

dries’s picture

dries commented

The new theme, called Xtemplate, is designed after the old Bluemarine theme but has some visual glitches and UI inconsistencies. Patches that fix or improve the theme are happily accepted.

dries’s picture

dries commented

Here is a list of glicthes when viewed with Opera 6 (Linux):

  • When comments are displayed in threaded/expanded mode, there is a variable height between the different comment blocks.
  • On some pages (example page) the sidebar does not stick to the right. (fixed)
  • There is a gab between the footer and the sidebar.
  • The footer is empty and should therefore be hidden.
  • On some pages (example page) the headers are way too large in comparison with other elements/headers. (fixed)
ax’s picture

ax commented

that could help in getting xtemplate.{theme|css} right? would be sufficient to just get the xtemplate.css and some static pages (like a node with many comments, a book page, a forum page, ...) from drupal.org and make them layout properly.

we would greatly appreciate any help on this.

synistar’s picture

synistar commented

but I do have some experience working with CSS layouts in a professional setting. I will download some pages from drupal.org and work on it a bit. My spare time is limited but I will try get some results by this weekend.

Can you point out what particular issues (besides the ones Dries posted above) you are having ?

bjergtrold’s picture

bjergtrold commented

Subject says all.

dries’s picture

dries commented

Better now?

bjergtrold’s picture

bjergtrold commented

Still to small, but we are getting there. Only local images are allowed.
Its pretty inconsistent, http://drupal.org/forum is illegible, but the deeper forum topics are ok.

noelvn’s picture

noelvn commented

Font sizes are OK in Mac Opera 6, but very mixed up & problematical in Mac MSIE 5.2 (these are the latest version for Mac OS X). In IE/Mac, on certain pages (documentation, forum main & topic-list pages) the main content area font is now so very small that it takes repeated application of the larger button to make it readable at all. However, this resizing causes the top and side menu text becomed ludicrously large, plus the page requires horizontal scrolling since it won't resize to accomodate this massive font size change.

On the forum topic-list pages, there's a very odd mix of font sizes: the descriptions are in 5 pixel micro-text (so tiny that letters are deformed), but 2 columns over, the "last post" column is in a normal small font. The font in news items' sub-comments is also uncomfortably small (and again, resizing to make it readable destroys the rest of the page layout). The comment attribution line is even smaller (deformed 5 pixel letters again).

This problem is definitely new in the last few weeks.

noelvn’s picture

noelvn commented

This MSIE Mac font size issue is now all fixed. (Thank you!)

synistar’s picture

synistar commented

This CSS script should fix the semi-random changes in spacing between forum
items. And it uses pixel sizing for fonts to eliminate unpredictable inheritance
patterns when using percentages (producing unreadable fonts). I also moved all the font size properties to a section of their own so you can easily adjust font sizes to your liking.



Cut Here

-------------------------------------------

<code>/* *** Global properties */
body {
  margin: 0px;
  padding: 0px;
  color: #000000;
  background-color: #fff;
  font-family: verdana, arial, helvetica, sans-serif;
}
a {
  text-decoration: none;
  font-weight: normal;
}
a:link {
  color: #378CE0;
}
a:visited {
  color: #036;
}
a:hover {
  text-decoration: underline;
}
p {
  margin: 0 0 1em 0; 
  padding: 0px;
}
img {
  border-width: 0;
}

/* *** Font Sizing */
body {
  font-size: 12px;
}
.menu #links #primary {
  font-size: 13px;
}
.menu #links #secondary {
  font-size: 12px;
}
#secondary input {
  font-size: 13px;
}
#footer {
  font-size: 9px;
}
.block .title,
.node .title,
.node .title a,
.box .title,
.box .title a {
 font-size: 14px;
}
.node .taxonomy {
  font-size: 10px;
}
.node .author,
.comment .author {
  font-size: 9px;
}
.comment .title {
  font-size: 13px;
}
.comment .new {
  font-size: 9px;
}
.block .content, .box .content {
  font-size: 11px/13px;
}

/* *** Theme properties */
.header .menu {
  background-color: #69c;
  padding: 5px 5px 0px 5px;
  /* */
  padding: 0.5ex;
  width: 100%;
}
.menu logo {
  vertical-align: bottom;
  float: left;
}
.menu #links {
  text-align: right;
  float: right;
  color: #9cf;
}
.menu #links #primary a {
  color: #fff;
  font-weight: bold;
}
.menu #links #secondary {
  margin-bottom: 12px;
}
.menu #links #secondary a {
  color: #9cf;
  font-weight: bold;
}
#secondary form {
  display: inline;
}
#secondary form .keys {
  width: 12em;
  margin-left: 1em;
}
#message {
  background-color: #369;
  padding: 10px 10px 10px 10px;
  color: #fff;
}
#message a, #message a:visited {
  color: #9cf;
  font-weight:bold;
}
#main {
  margin: 10px 10px 10px 10px;
  padding: 15px 15px 0px 15px;
}
#sidebar {
  background-color: #ddd;
}
#footer {
  background-color: #eee;
  padding: 15px 10px 5px 10px;
}
table .node {
  padding-bottom: 25px;
}
table .block, table .box {
  padding: 15px 15px 15px 15px;
  margin: 5px 0px 5px 0px;
}
table .comment {
  border: 1px solid #bbb;
  padding: 15px 15px 15px 15px;
  margin: 5px 0px 5px 0px;
  margin: 0px 0px 5px 0px;
}
.node .title, .block .title, .box .title, .node .title a, .box .title a {
  padding-bottom: 5px;
  font-weight: bold;
  color: #888;
}
.node .author, .comment .author {
  color: #999;
  padding-bottom: 10px;
}
.node .taxonomy {
  color: #999;
  padding: 15px;
}
.node .taxonomy a {
  color: #369;
}
.node .content, .comment .content {
  padding-top: 5px;
}
.node .links, .comment .links {
  padding-top: 10px;
  color: #999;
}
.node .links a, .comment .links a {
  font-weight: bold;
  color: #369;
}
.comment .title {
  font-weight: bold;
  color: #888;
}
.comment .new {
  text-align: right;
  font-weight: bold;
  float: right;
  color: red;
}

dries’s picture

dries commented

Can you post this on the mailing list as a patch? If not, I'll try to figure out the changes later.

synistar’s picture

synistar commented

  • When comments are displayed in threaded/expanded mode, there is a variable height between the different comment blocks.

This one is due to the fact that margins merge when you put two of them together (a 5px margin-bottom plus a 5px margin-top on the next element = a distance of 5px between the two elements). But if you put a table open or close tag between them they stop collapsing since both of them consider the table another element (so a total of 10 px is shown since both elements keep 5 px between themselves and the table tag).

Change line 101 (after the selector "table .comment {") in xtemplate.css to read: 

margin: 0px 0px 10px 0px;


That should fix it by using 1 bottom margin of 10px instead of two combined 5px top and bottom margins.

dries’s picture

dries commented

Thanks synistar. I tried the suggested change but that doesn't fix the problem.

Anonymous’s picture

(not verified) commented

The screenshot link in the front page gives error.

Anonymous’s picture

(not verified) commented

seems to be a permissions problem

dries’s picture

dries commented

I just gave everyone access to view the images but now there is another error, so it seems.

killes@www.drop.org’s picture

killes@www.drop.org commented

We need new screenshots. The admin menu got so much nicer.

--
Drupal services
My Drupal services

killes@www.drop.org’s picture

killes@www.drop.org commented

I only see (replies: ) ie no number. I am not sure what causes this, maybe it is comment_num_replies. What does watchdog say?

--
Drupal services
My Drupal services

moshe weitzman’s picture

moshe weitzman commented

must be a bug

dries’s picture

dries commented

Fixed as of a minute ago.

eafarris’s picture

eafarris commented

I filled out a bug report and hit preview, got an empty page except for the header and right-hand boxes.

ax’s picture

ax commented

must be a permission problem (authenticated users need "maintain bug reports" permission).

ax’s picture

ax commented

(see Using TortoiseCVS for an example - it's not listed in the parent) because "moderate" gets set to 1 (see http://lists.drupal.org/pipermail/drupal-devel/2003-February/021654.html). and i cannot set moderate to 0 because there is no "moderate" show in the admin page.

wasn't this fixed already? please do so.

dries’s picture

dries commented

I was fixed but it has been reintroduced by Kjartan's node API changes. As of that commit, the "moderate" option is only shown when the queue module is enabled (which we don't want here on drupal.org).

ax’s picture

ax commented

it certainly doesn't encourage people to update the book when that page doesn't get listed afterwards anymore ...

grugnog@yahoo.com’s picture

grugnog@yahoo.com commented

The contributions CVS access page. It's broken. It implodes with great force.

- Grugnog

Anonymous’s picture

(not verified) commented

warning: Wrong parameter count for method_exists() in /var/www/drupal.org/modules/image.module on line 969.

Anonymous’s picture

(not verified) commented

As per subject.

Anonymous’s picture

(not verified) commented

Er, actually, there's a horizontal scrollbar, but it doesn't actually scroll all the way over to the edge of the menu bar. Several of the menu items on the far left in the "About Drupal | Documentation ...." menu are not visible unless the browser window is maximized (at 1280x1024 - I didn't check at other resolutions).