Currently the Customer module removes the fieldset around address fields that are displayed in the context of the checkout form or customer profile reference manager widgets (i.e. order add / edit form). This is a bit of that "magic configuration" that we worked hard to stamp out of the Add to Cart form / product attributes systems. In this case, I think it would be preferable for the Customer module to add a checkbox option to address field settings on Customer Profile entity types to remove this fieldset that defaults to TRUE.

I came across this issue b/c I was updating the code to fix #1234258: Update commerce_customer_field_widget_form() to remove the fieldset from any address field when I realized this wouldn't properly accommodate profile types with multiple address fields (be they few and far between). Right now I'm just leaving the fieldset in the case of multiple address fields, but it would be nice to give the administrator the option to remove it around just one.

CommentFileSizeAuthor
#1 remove-fieldset-1241566.patch3.83 KBtwistor

Comments

twistor’s picture

Status: Postponed » Needs review
StatusFileSize
new3.83 KB

I came across this issue after getting an error on the order edit page when using commerce_shipping. The current logic assumes all each addressfield will be on each profile. A minor error, but this seemed like a good idea.

The title of the checkbox probably needs help, I'm terrible at user facing text.

monsoon’s picture

Hi, Is this patch added to dev version? I want to remove the fieldset but don't know how to do so by git?

Status: Needs review » Needs work

The last submitted patch, remove-fieldset-1241566.patch, failed testing.

rszrama’s picture

Priority: Minor » Normal

Patch is likely very out of date by now unfortunately.