Hi all,
I know the code specifically says gmap_draw_map is not working yet. I am not writing to complain :) I am wanting to figure out the status, and see if there are already plans to work on this (we've used it for overriding a view to plot nodes, in 4.7, we should still use this, no?) and if it is just awaiting some lovin' from someone, to see if I can volunteer for the task. We looked at it briefly, but there were a couple things going on w/ it. Before readdressing it on our end, I wanted to make sure it was not already being worked on by anyone.

thanks!
Ian

Comments

bdragon’s picture

bdragon commented

I'm planning on killing it once I find the rest of the instances and fix them. I should probabaly change the error message to say something along those lines.

After that, I'll write documentation on what users should do to convert their customizations over.

Since it has a parameter for adding javascript to the page directly, it has to go. This sort of thing is bad behavior in Drupal 5. The correct way is to put your custom functionality in a js file and drupal_add_js it to the page when you need it (I suggest doing it in a theme function.)

A lot of the behavior that was custom before is becoming standard, and you can just flip it on by setting a behavior flag or two in the #settings array on a 'gmap' element (A form element in the new code that draws a map for you.)

Even if it doesn't become standard, you can add your own flag and check it on the javascript side. I haven't documented this yet, but this means you can turn on and off stuff like the keyboard handler per-map.

Ian Ward’s picture

Ian Ward commented

Hi Brandon,
Thanks for writing back. What I was doing before to make maps and theme them out was using http://drupal.org/node/61335. I will check out the gmap_element and see if I can figure out how it is working now.

Thanks for all the work you've done w/ this for 5

Ian

bdragon’s picture

bdragon commented
Status: Active » Closed (won't fix)