Menu attributes form not displayed

And the patch.

Btw, I think that our branches are kinda messed up ATM. I propose that we create a 6.x-2.x branch before applying this patch.

I investigated this a bit so you won't have to waste your time with it. The problem was introduced in #1200932: Menu Attributes overwrites menu link option set by other modules. I know, my bad. In my defense, the tests I wrote for 7.x-1.x will prevent us from doing this mistake again :)

Before that patch, $form['options'] was being overridden and it's #type was FAPI's default markup. After the patch, $form['options'] keeps it's previous type, which is value.

The problem with setting $form['options'] to item or markup is that it gives us a nasty 'Array' printed just above our fieldset, so I see no other option than moving the whole structure outside of $form['options'] and transfer our values over there in a validate handler.

I'll think about it some more and come up with a patch in a day or two.

Finally, here's a patch with the approach from #3 :)

Then #1 should do the job.

I can't reproduce the problem in D7 but I think it should be applied, just to be on the safe side.

After trying various things using the patch from #1 as the starting point, the fix is even simpler, we just need to set the #type to 'form', and there's no naggy 'Array' printed anywhere. #facepalm for wasting a few hours on this during the Drupalcon London code sprint :(

After inspecting the document source (not just FIrebug), this actually puts another
element in our existing form, so disregard the patch from #10.

The patch from #1 brings us back to the situation from #1200932: Menu Attributes overwrites menu link option set by other modules and I could find no other alternatives with D6's Form API. Dave, can you reconsider #5? :)