Refactoring of the handle method of RESTServer.

There is no need to extract $leaf and then put it back in to $path when we determine formatter.

Attached patch shows shorter way.

CommentFileSizeAuthor
#4 services-1241830-extract-formatter-D6.patch2.35 KBygerasimov
#4 services-1241830-extract-formatter-D7.patch4.1 KBygerasimov
#3 simplify-plus-patch.patch2.22 KBmarcingy
#2 services-1241830-extract-formatter-D6.patch2.33 KBygerasimov
#2 services-1241830-extract-formatter-D7.patch1.58 KBygerasimov
0001-Refactor-determine-formatter.patch1.92 KBygerasimov

Comments

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Needs work

This patch doesn't apply either, ARG

ygerasimov’s picture

ygerasimov commented
Status: Needs work » Needs review
StatusFileSize
new services-1241830-extract-formatter-D7.patch1.58 KB
new services-1241830-extract-formatter-D6.patch2.33 KB

Here are both patches for D6 and D7.

marcingy’s picture

marcingy commented
StatusFileSize
new simplify-plus-patch.patch2.22 KB

Tests are failing

ygerasimov’s picture

ygerasimov commented
StatusFileSize
new services-1241830-extract-formatter-D7.patch4.1 KB
new services-1241830-extract-formatter-D6.patch2.35 KB

There was failing test on D6. Thanks for catch @marcingy.

I have added test of testEndpointMenu() to D7 like is in D6 for consistency.

Now all tests pass. There are several exceptions, but they are not connected with these changes anyway.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Reviewed & tested by the community

These look great. Tests pass for me.

ygerasimov’s picture

ygerasimov commented
Status: Reviewed & tested by the community » Fixed

Committed to both 6.x and 7.x branches. Thank you for review!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.