Needs review
Project:
Workbench
Version:
7.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Aug 2011 at 19:22 UTC
Updated:
24 May 2013 at 05:22 UTC
Jump to comment: Most recent file
Comments
Comment #1
domineaux commentedI just found this docs, looks like it may be a big help
http://drupal.org/node/1171018
Again, thanks for what appears to be an excellent module
Comment #2
domineaux commentedIt would help alot to understand just what each line item means in permissions
I just did a copy paste from admin/people/permissions - and the array is down in lieu of across.
Regardless, you can view the permissions on your site and see what I'm talking about.
Some of the terms are easy, some not so easy to understand just what they do and how various users affected.
--------------------------------------------------------------
Workbench
Line 1
Administer Workbench settings
anonymous user: Administer Workbench settings
authenticated user: Administer Workbench settings
contributor: Administer Workbench settings
Author: Administer Workbench settings
Editor: Administer Workbench settings
administrator: Administer Workbench settings
Line 2
Access My Workbench
anonymous user: Access My Workbench
authenticated user: Access My Workbench
contributor: Access My Workbench
Author: Access My Workbench
Editor: Access My Workbench
administrator: Access My Workbench
Workbench Access
Administer Workbench Access settings
anonymous user: Administer Workbench Access settings
authenticated user: Administer Workbench Access settings
contributor: Administer Workbench Access settings
Author: Administer Workbench Access settings
Editor: Administer Workbench Access settings
administrator: Administer Workbench Access settings
Etc, Etc.
Comment #3
robeano commented@davereid told me just now that we can add descriptions to permissions. I would like to add the descriptions for sure and perhaps followup with a handbook page on d.o
Comment #4
agentrickardNote that anyone can add documentation to the handbook.
https://drupal.org/documentation/modules/workbench
Comment #5
drupalmonkey commentedAdded descriptions for the permissions in Workbench, I'll make tickets in the other WB modules to update their permissions.
Comment #6
barrapontoComment #7
agentrickardI don't think you can put links in the descriptions like that without checking for access to the links. Generally, links are not added to descriptions.
Comment #8
barrapontoSwitching to l() would give us access checks.The descriptions must make sense even if they're not linking anywhere.
BTW, core filter and user modules have links in their permissions titles and descriptions. They follow the same pattern as those in the patch, using url().
Comment #9
agentrickardThe UX team guideines I've seen would say that these descriptions don't add enough extra context to be worth adding.
Comment #10
barrapontoShould we try better descriptions that added more context?
Comment #11
agentrickardI would.
Comment #12
damontgomery commentedThe only two permissions that are only for Workbench (not other sub modules) are "Administer Workbench Settings" and "Access My Workbench".
The only confusion I can see is that once Workbench Access is also used, there is confusion with the repetition of "access".
I recommend simply following the naming convention in the rest of the core permissions and change "Access My Workbench" to "Access My Workbench Pages". This doesn't seem like much of an improvement, so we could stray a little bit and use "View My Workbench Pages".
domineaux, can you provide more information on what part was confusing? Since this issue is so old and it's unclear what the confusion was, it might be a good idea to closed (won't fix) this issue.