I got this message after typing in address bar of my browser: example.com/admin/content?sort[]
Warning: strtolower() expects parameter 1 to be string, array given in tablesort_get_sort() (line 238 of ..../includes/tablesort.inc).

CommentFileSizeAuthor
#6 invalid_type_of_GET_variable-1242480-5.patch1.67 KBgalooph

Comments

catch’s picture

catch
he/him
Primary language English
commented

@Chi - would you consider combining these patches into one (possibly excepting the search patch that is already RTBC)? Would be easier to track in one issue I think, and all the patches are individually very small.

chi’s picture

chi commented

I thought about it. All these problems have a common cause but in fact, all patches will be very different.
So it would be easier to fix it in separate issues. Fixes some of these issues can take a long time.
We can add some tag for easier tracking.

chi’s picture

chi commented

Another reason why we should separate these issues that some of these patches may not needs backport to D6.

catch’s picture

catch
he/him
Primary language English
commented

OK those are good reasons for separate issues :)

galooph’s picture

galooph commented
Status: Active » Needs review
StatusFileSize
new invalid_type_of_GET_variable-1242480-5.patch1.67 KB

Cast $_GET['sort'] as a string.

Test included in patch.

xjm’s picture

xjm
she/her
Primary language English
commented

See: #1242472-15: Invalid type of $_GET variables causes PHP warnings and notices when treated as strings .

Edit: Basically, we should cast all these values as strings immediately when we assign them from $_GET.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: Unassigned » xjm
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Closed (duplicate)

Marking as duplicate of #1242472: Invalid type of $_GET variables causes PHP warnings and notices when treated as strings to work on a more global solution.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » Unassigned