Closed (fixed)
Project:
Facet API
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Aug 2011 at 09:33 UTC
Updated:
4 Jan 2014 at 01:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
cpliakas commentedConfirmed. Marking as "needs review".
Comment #2
cpliakas commentedGreat job finding this bug, and the attached fix works as described. The one piece that is missing is that if the list is expanded and a bookmark is selected, the list collapses itself again.
Instead of using once(), how about adding an additional condition next to the
if (settings.limit > 0testing if the "facetapi-processed" class is set? If it is not set, set it via something like$('ul#' + settings.id).addClass('facetapi-processed');. If it is set, skip processing that entire function which will ultimately take no action when a flag is selected.Great job discovering this,
Chris
Comment #3
cpliakas commentedPutting this on the low hanging fruit list. Really looking to have MrHaroldA or someone else drive this home.
Comment #4
mrharolda commented@cpliakas: I might have some time this week to look into it. Can't promise it though... ;)
Comment #5
cpliakas commentedThe attached patch is what I was thinking. Committed at b486e61.