apart from the warnings I have not noticed any other side effects

warnings:
warning: Illegal offset type in /home/xiosweb/public_html/dru/modules/taxonomy/taxonomy.module on line 1162.
warning: Illegal offset type in /home/xiosweb/public_html/dru/modules/taxonomy/taxonomy.module on line 1163.
warning: Illegal offset type in /home/xiosweb/public_html/dru/modules/taxonomy/taxonomy.module on line 1166.
warning: Illegal offset type in /home/xiosweb/public_html/dru/modules/taxonomy/taxonomy.module on line 1162.
warning: Illegal offset type in /home/xiosweb/public_html/dru/modules/taxonomy/taxonomy.module on line 1163.
warning: Illegal offset type in /home/xiosweb/public_html/dru/modules/taxonomy/taxonomy.module on line 1166.

test case system:
drupal 5.1
pathauto latest dev (I believe patches from http://drupal.org/node/92900 are already applied but I could be wrong)
// $Id: pathauto_node.inc,v 1.29.2.3 2007/02/05 18:31:41 greggles Exp $
// $Id: pathauto.module,v 1.44.2.5 2007/01/20 23:26:24 greggles Exp $
localizer latest enabled
cck latest enabled

test case that DOES NOT produce warnings:
after creating a node there is a link to "translations"
there you can click on "create translation" and it takes you to
node/add/page/localizernode/3/el (el is the language code)
this wont produce any warnings (default node type)

test case that DOES produce warnings:
but on cck created node type produces the warnings
for example same procedure as before but "create translation" takes you to
node/add/property/localizernode/1/el

I am not assuming that it is pathauto
but very similar errors with http://drupal.org/node/92900

there is three players involved just documenting it here
and as a Localizer issue earlier http://drupal.org/node/119079 (but CCK was not known to be involved there)

a very important thing to note is that
taxonomy.module file has been patched by the localizer module (part of the installation process)
so 1162-1166 lines correspond to function "taxonomy_get_term"

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Postponed (maintainer needs more info)

Does the problem still happen on sites without localizer and without the localizer patch?

Does the problem still happen if you disable pathauto?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

And I agree, it is very similar to other common pathauto errors, but I just want to make sure before I try to reproduce it.

giorgosk’s picture

giorgosk
Location Chios, Greece 🇬🇷
commented

greggles

after some further investigation and tracing I discovered that

a node created from Localizer enters your node_get_placeholders()

and line 202 elseif (is_array($value)) { is false

and therefore 

//line 209
      elseif ($value) {
         $first_term_id = $value;
           break;
      }

gets executed which gives $first_term_id = NULL
and therefore taxonomy_get_term complain about the NULL

this is happening because 

$node->taxonomy = array(
  "1" => array("tid" => 1 , "vid" => 3, "name" = "cat1", description=>"" , weight => 3),
  "4" => array("tid" => 4 , "vid" => 4, "name" = "cat4", description=>"" , weight => 3)
)

as created by localizer code

while on line 202 you are expecting something like this 

$node->taxonomy = array("","1","4");

is there a convention on how the node->taxonomy should look like or are both legitimate ?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

In Pathauto5.x-2.0 the whole taxonomy parsing stuff has changed in a way which should solve this. So, I encourage you to test that version. If you still get the problem we can investigate this more, but until then I'm going to close the issue.

FWIW, I think the convention is whatever Drupal core does, which is apparently not how localizer does it ;)