Hi,

This module worked great for me when I was using Drupal 4.7, but then I upgraded to Drupal 5.x. Is there any way someone can help update this to be compatible with Drupal 5.x?

Thanks!

CommentFileSizeAuthor
#7 tellafriend_2.patch21.31 KBGurpartap Singh
#6 tellafriend_1.patch21.3 KBGurpartap Singh
#4 tellafriend.module.txt9.95 KBGurpartap Singh
#2 tellafriend_0.patch21.34 KBGurpartap Singh

Comments

mishhh’s picture

mishhh commented

I second that...

Gurpartap Singh’s picture

Gurpartap Singh commented
Title: Update for Drupal 5? » Update for Drupal 5
Assigned: Unassigned » Gurpartap Singh
Status: Active » Needs review
StatusFileSize
new tellafriend_0.patch21.34 KB

Please review..

jwolf’s picture

jwolf commented

After applying patch, I now get:
Fatal error: Call to undefined function: form_textfield() in tellafriend.module on line 90

Also, the patch has some file path references as C:/Documents and Settings/Waheguru/Desktop/...

Gurpartap Singh’s picture

Gurpartap Singh commented
StatusFileSize
new tellafriend.module.txt9.95 KB

Did your patch really apply? Search for form_textfield in the patch, you'll find all of them with the minus sign on the left. Anyways, attached is the complete .module file(rename to tellafriend.module). No patching needed. Just make a tellafriend.info with this content:

name = Tell a friend
description = Allows you to create a Tell-a-Friend page to spread the word about your site.

It has been tested to work well. The email is sent indeed :) Try it yourself on: http://www.sikhism101.com/ Just launched it a minute ago :)

jwolf’s picture

jwolf commented

Correction: no longer getting the Fatal error. It was caused by reapplying the patch to the already patched module.
I had reapplied the patch after I got an error message about the Windows file path references.

Gurpartap Singh’s picture

Gurpartap Singh commented
StatusFileSize
new tellafriend_1.patch21.3 KB

Some fixes...

Gurpartap Singh’s picture

Gurpartap Singh commented
StatusFileSize
new tellafriend_2.patch21.31 KB

When using multiple addresses, all the inviteS were sent to only the first email. Fixed in this patch.

thierry_gd’s picture

thierry_gd commented
Status: Needs review » Fixed

Modifications taken into account in drupal 5.x version

djpinoy’s picture

djpinoy commented

Wow. Talk about luck. I was actually fixing to sit down and start taking a look at fixing this today when I saw that all the changes seem to have already been made! Thanks! I'll be testing this out for a bit and will report back any bugs that I find. If it seems to work through the next week or so, I'll come back and close the feature request.

Thanks again!

Gurpartap Singh’s picture

Gurpartap Singh commented

You don't need to close an issue by yourself. It'll get auto closed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)