Closed (fixed)
Project:
Sort Comments
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
9 Aug 2011 at 01:21 UTC
Updated:
22 Dec 2011 at 17:10 UTC
Jump to comment: Most recent file
Firstly, thanks for the useful module, this should really be a feature in core.
When modifying the node type edit form, Drupal automatically includes newly added form elements as config variables into the variable table.
To that end, there's no need to add your own submit handler and separate, duplicate, config var.
The current code creates two config variables in the database
* comment_default_sorting_[type]
* sort_comments_[type]
with the same value.
The attached patch removes the unneeded code and uses the default created comment_default_sorting_[type] variable instead.
Cheers,
DT
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 1243390-sort_comments.module.patch | 2.02 KB | davidwhthomas |
| sort_comments.module.patch | 2.05 KB | davidwhthomas |
Comments
Comment #1
davidwhthomas commentedRemoved commented out debug line.
Comment #2
maurizio.ganovelliThanks davidwhthomas,
i'll review and commit your patch as soon as possible (i'm currently on summer holiday!).
Bye.
Comment #3
maurizio.ganovelliCommitted to repository