Needs review
Project:
Websnapr Field
Version:
6.x-6.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Aug 2011 at 14:00 UTC
Updated:
19 Jan 2012 at 21:33 UTC
Jump to comment: Most recent file
Comments
Comment #1
danepowell commentedsub- websnapr_field is completely useless until this is resolved.
Comment #2
gzett commentedThe problem with the new Websnapr code is, that they are using javascript. The javascript file must be loaded from websnapr, because they are using a hash code, to check the age of the file. But Drupal 6 does not support external js-files.
I have a suggestion for the problem:
Comment #3
jvinci commentedfollowing
Comment #4
queryblitz commented+1
Comment #5
monstordh commentedHas anyone used this code? Does it resolve the issues with the new code without any problems?
Comment #6
discipolo commentedindeed, it works
Comment #7
discipolo commentedreuploading as patch
Comment #8
danepowell commentedAre you guys aware that this has already been "fixed" in dev? See #1062678: new websnapr code
Note that they take a rather different approach to solving this there- loading the script on hook_init(). I think the approach in #7 is probably better as it doesn't use hook_init(), but I'm not sure. Thoughts?
Note that the patch in #7 is not a valid Git patch and needs to be re-rolled WRT 6.x-dev regardless.
Comment #9
discipolo commentedtry of reroll
Comment #10
danepowell commentedOkay, here's a patch WRT HEAD. It adopts the 'meat' of the code added by the other issue, #1062678: new websnapr code, but removes the hook_init() and replaces it with the drupal_add_js() proposed in #9. I've tested it and it seems to work fine.