When editing a user, the CAS settings page is located beneath the "Edit" or "User settings" tab. However, the OpenID settings page, which provides essentially identical functionality, is located at the same level as the user settings tab, not beneath it. See the attached screenshot.
Because the CAS and OpenID pages are so similar, they should really be at the same menu level for good UX. Either CAS should be bumped up a level in the menu, or OpenID should be put beneath the "edit" / "account settings" tab.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 1244258-fix_tab_parent.txt | 576 bytes | bfroehle |
| #2 | before.png | 18.46 KB | danepowell |
| #2 | after.png | 17.22 KB | danepowell |
Comments
Comment #1
bfroehle commentedDane: The screenshots weren't attached successfully.
In terms of implementation, the difference between CAS and OpenID comes in the returned key 'tab root' in hook_menu(). Compare:
vs.
I have no objections to removing the tab_parent line. Could you generate a few screenshots to show the before and after UI for comparison?
Comment #2
danepowell commentedHere's the before and after screenshots...
Comment #3
bfroehle commentedDave: Any objections to Dane's patch?
Dane: Was the patch merely removing the tab_parent line? Or did you adjust the weight as well?
Comment #4
danepowell commentedAll I did was to remove the tab_parent line.
Comment #5
metzlerd commentedI have no objections. Thanks for asking.
Comment #6
bfroehle commentedCommitted to 6.x-3.x.