memcache/memcache.inc
Line in question

    $key_length = isset($wildcard_flushes[$table]) ? strlen(reset(array_keys($wildcard_flushes[$table]))) : $length;
CommentFileSizeAuthor
#3 memcache-fix-strict-warning-about-pass-by-reference-1244296-3.patch759 bytesdas-peter
#1 memcache-1244296-1.patch1.33 KBmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new memcache-1244296-1.patch1.33 KB
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Thanks! Committed and pushed.

das-peter’s picture

das-peter commented
Status: Fixed » Needs review
StatusFileSize
new memcache-fix-strict-warning-about-pass-by-reference-1244296-3.patch759 bytes

@catch: sorry for the duplicate in #1131370-15: Segment wildcard counts by $string[0] - I forgot do to a pull first d'oh!

Looks like I've found a follow up to this issue - there's another location where reset() is used with a function return: line 299 in memcache.inc

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Thanks, committed and pushed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.