default patterns should not be "dangerous"

greggles - March 3, 2007 - 19:12
Project:Pathauto
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:greggles
Status:closed
Description

Some of the default patterns are "dangerous" - http://drupal.org/node/73232 - and should be changed.

Currently all of the patterns are dangerous to one extent or another.

#1

greggles - March 20, 2007 - 14:34
Priority:normal» critical
Assigned to:Anonymous» greggles

and I consider this critical (and will fix it shortly) now that we've got the 2.x branch I can change defaults again. Yay!

#2

greggles - March 24, 2007 - 08:44
Status:active» reviewed & tested by the community

how about the following default patterns

- $settings['patterndefault'] = t('[title]');
+ $settings['patterndefault'] = t('content/[title]');

- $settings['patterndefault'] = t('[vocab]/[catpath]');
+ $settings['patterndefault'] = t('category/[vocab]/[catpath]');

- $settings['patterndefault'] = t('user/[user]');
+ $settings['patterndefault'] = t('users/[user]');

- $settings['patterndefault'] = t('blog/[user]');
+ $settings['patterndefault'] = t('blogs/[user]');

- $settings['patterndefault'] = t('user/[user]/track');
+ $settings['patterndefault'] = t('users/[user]/track');

As far as I can tell, this is RTBC. I'll let folks comment over the next few days and then commit it to the 5.2 branch.

AttachmentSize
non_dangerous_defaults.patch 3.64 KB

#3

greggles - March 25, 2007 - 22:18
Version:5.x-1.x-dev» 5.x-2.x-dev
Status:reviewed & tested by the community» fixed

webchick +1'd the idea, so I committed it. I'll still take feedback, but at least this is a start.

#4

Anonymous - April 8, 2007 - 22:31
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.