User relationships not working as expected (version 2)

Subscribing, I see this also.

We've had various people notice this in the 2.0 release; I think we've whacked this issue here: #1256722: Awkward language around "following", unclosed div tag in status messages

The final comment here #1256722: Awkward language around "following", unclosed div tag in status messages does not fix this issue.

Still big issues around the 'Follow' relationship.

Big enough that potentially a show stopper for me trying to sell Commons to my new employer....eeek!!

Commons 2.0 was buggy out the box and didn't seem to deliver what it promised.

The major issue still apparent here is NOT having the ability to 'Follow' somebody who has chosen to 'Follow' you. One can only select to 'Unfollow' the person despite having never chosen to 'Follow' them before.

I hope this makes sense!

Thanks

Still an issue with out of the box 6.x-2.0.
and not a duplicate of http://drupal.org/node/1256722 which is related to language and conformations not the fact that two users can not mutually follow on another.

If A follows B, the following box on both A and B increments one, making the count incorrect on B's account.
In addition if user B goes to User A's page they see an Unfollow button not a follow button.
They are therefor unable to follow A.
In addition if use B clicks that unfollow it removes the A->B follow relationship which I would have assumed was "owned" by A and should not be editable by B.

If I manually create a follow request url
http://localhost/commons/relationship/[a_uid]/request/[a_uid]?destinatio...
B is able to follow A, so it is possible to follow properly, but the button used on the account page is faulty in it's detection of relationships. As is the count on the following block.

One last thing that seems "wrong" If user A follows user B a message is generated in User A's stream, but not in user B's stream. Though user B does not follow user A a notification and message in their stream seems appropriate.

I am running locally on windows XAMPP for Windows Version 1.7.3 if that helps.

this seems to be dependent on the output of _user_relationships_ui_actions_between() so this might be a issue for user_relationships, or a it may be a misuse of that function.

commons_profile.blocks.inc
line 108
this seems to assume that only one action will be returned, or perhaps assumes that the last action in the list will be the one that is desired. Perhaps this is inconsistent across PHP versions.

$actions = _user_relationships_ui_actions_between($user, $account);
foreach ($actions as $key => $action) {
        $links["ur_action"] = array(
          'title' => $action . 'action',
          // No href because this is the best that UR can offer
          'html' => TRUE,
        );
      }

the following shows both the follow and unfollow actions.
but I'm not sure that _user_relationships_ui_actions_between can give you a single correct value.

 $actions = _user_relationships_ui_actions_between($user, $account);
foreach ($actions as $key => $action) {
        $links["ur_action_".$key] = array(
          'title' => $action,
          // No href because this is the best that UR can offer
          'html' => TRUE,
        );
      }

Just thought I would check in on progress with this, looks like its still an issue.

I would have thought the guys at Acquia Commons would have been far more "on it" with a bug so fundamental in the functionality of a "social" network.

Really disappointing.

I am fighting with my supervisor right now.....

Her stand point:

"Open source or not.....don't release something which has such basic issues in its main functionality, doesn't inspire confidence."

I can't really argue, apart from I appreciate that open source is looked after by the community. With Commons though I guess I expected more as its a distribution that has been created and pushed by Acquia as a product that can compete with the likes of Lithium, Jive, BuddyPress....

Can it really?

Right now I don't even know where to go to get documentation or support. Acquia website has nothing but a few promotional videos, commons.acquia community....well frankly....its just a mess and I don't think anybody is even monitoring it...and the acquia sales team have no idea of the potential of the product.

Is this a deliberate ploy on Acquia's part to get people to sign up and pay for their support?? It feels like it....and if so...why not just charge for a distribution that works?!?

Sorry for the rant.....especially here....but where else can I go!!

Thanks guys.

Must admit I'm getting confused about subscriptions, notifications and following. Also a bit confusing that there's a daily digest function in profile settings but not ability to set notifications to go into a daily digest.

I think I'm right in saying that subscriptions are the same as notifications, and will email out posts by a user I have subscribed to as long as I have access to see those posts. So presumably posts in mutual groups and public posts, which would also go into one's stream. I'm not sure about Open groups that aren't mutual, but I'm not overly concerned about that.

Does following give me greater access to see a user's posts even if they're posted in a group I don't belong to? I wouldn't like that. And if it doesn't, I'm not sure I totally see the point of it either because it would be the same as subscriptions, except for the fact there's that public notice that I'm following this person.

I've turned off relationships in permissions, which quite neatly removes the related menu pages and follow links.

The language around relationships in the menu (i.e. 'My Relationships'!) in Commons had my first training session giggling... If this functionality sticks around, it could probably be better as something more generic! Associates, contacts, connections? I don't know if it's just a UK thing but relationships would usually spring to mind as a particular group of either family or lovers (in fact, mainly just lovers, i.e. 'We're in a relationship'), even if it doesn't exactly mean that!

Okay I sort of understand the digest thing now. By default Commons sends out a daily digest of activity stream occurrences. Although I've not actually seen one of these digests yet... and everything seems setup right.

Notifications/Subscriptions send out an immediate notification of new content areas subscribed to.

Subscribing

subscribing

Just wanted to let folks know that this is on the top of our radar following #1298378: Identify undocumented contrib changes, which needs to be addressed so that we can update User relationships to the latest version.

We'll be sure to update this issue with the latest progress here.

With regard to the count on the friends block I modified the following line in /profiles/drupal_commons/modules/features/commons_profile/commons_profile.module:

Commented line 128:
//$friends = user_relationships_load(array('user' => $account->uid, 'approved' => TRUE), array('count' => TRUE));

And inserted this line:

$friends = user_relationships_load(array('user' => $account->uid, 'requester_id' => $account->uid), array('count' => TRUE));

This way the it only counts the relationships where the current user is the requester.

However, I can't find any solution to the "unfollow" button issue, any advances in this sense?

subscribing

subscribing

Any advances on this issue? I can help if some guidance is provided...

subscribing

I sent a possible temporary solution to another thread http://drupal.org/node/1307148#comment-5116830

This seems to be a bug in the User relationships module: #651502: clarify reciprocal & one-way relationships .

I've filed a patch against the User relationships module to fix this bug. It would be great to get some testing at that issue: http://drupal.org/node/651502#comment-5228656

I exchanged screenshots with Berdir at #651502: clarify reciprocal & one-way relationships , and he helped to clarify how reciprocal relationships work in the User relationships module on a fresh install of Drupal. As a result, it seems like UR does not need the patch from #651502 applied.

However, there are some issues with the way Commons unsets everything from $user->content in hook_user() case 'view', and replaces that output with content provided by the _commons_profile_image_links_block_view() block.

A main issue is that User relationships provides several links to add and remove relationships, and commons_core iterates over the links but overwrites the value in the $links array by using the same key for each one.

The attached patch corrects this and allows links from multiple relationship types to be present and retain the ur_action class that causes them to be styled as a button by the Commons themes.

Note, this applies to the Drupal.org repository and requires an unmodified (beyond the patches in the drupal_commons.make) version of User relationships.

Rewied. Thanks.

This is committed: http://drupalcode.org/project/commons.git/commitdiff/b58623f?hp=9d590073...