UTF8 encoding

nterbogt - March 3, 2007 - 23:33
Project:OpenSearch Client
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

The result list built by magpie RSS doesn't appear to be UTF8 encoded correctly. This patch loops through the result fields for each result, encoding the variable to UTF8 using PHP's utf8_encode.

AttachmentSize
opensearchclient_encoding_problem.patch559 bytes

#1

nterbogt - March 23, 2007 - 04:02

There is more to this than I orginally thought. The patch above also replaces < with < which is less than helpful when you have emphasied text in your titles. I'll have to think about this a little more.

#2

robertDouglass - May 21, 2007 - 07:25
Status:needs review» fixed

I came up with a slightly different solution. Please test.

#3

nterbogt - May 22, 2007 - 00:15
Status:fixed» active

This is essentially the same patch that I made (or at least, the change that is in my development environment) and it doesn't seem to fix the problem.
To let you know where I'm at... the UTF8 encoding is correct in the OpenSearch RSS Feed from Nutch... but by the time it hits the output page of Drupal's search API... it's incorrect. I haven't had time to look into where the bug is but I'm going to test the search results rendering functions... the output from Magpie and the opensearchclient_search functions.
I'll let you know where I'm up to where I get a chance to look at these possible causes.

#4

robertDouglass - May 22, 2007 - 07:37

I'm of the opinion that the problem is in the magpie library. The next step for this module, in my opinion, is to drop magpie and make simplefeed module a requirement, thus depending on the simplepie RSS library used there. I'm not going to research this any more but will look at any patches that you come up with.

#5

nterbogt - June 26, 2007 - 06:17

I've implemented an opensearchclient that uses the simplepie library for getting the RSS from a server. One problem with it is that the integration with the old (no longer maintained) nutch module is now broken. I know this is your module too Robert, so how attached to it are you?

Happy to produce a patch/something for you to check out the changes if you'd like.

#6

robertDouglass - June 27, 2007 - 06:44

It would be fine to move forward with opensearch client minus nutch. A big plus one for simplepie. Shall I make you a maintainer and let you lead the charge?

#7

robertDouglass - June 27, 2007 - 06:45

You are now a maintainer of this module. Please make it rock!

 
 

Drupal is a registered trademark of Dries Buytaert.