Warning when all bundles removed from an entity

Look sensible as far as I can see.

+++ b/modules/field/field.info.inc
@@ -678,7 +678,7 @@ function field_info_instances($entity_type = NULL, $bundle_name = NULL) {
-  if (!isset($bundle_name)) {
+  if (!isset($bundle_name) && !empty($info['instances'][$entity_type])) {
     return $info['instances'][$entity_type];
   }

I think we need to use a ternary operator in the return value - otherwise, we're not entering the condition when we're supposed to.

Second, this looks important enough for me to require tests.

20 days to next Drupal core point release.

This is the syntax I'm used to for this type of double-optional function which also makes the most sense to me. Adding tests.

Revised patch, passes tests.

Code looks good, however the test is wrong :
$instances = field_info_instances('test_entity'); is always keyed by the bundles known for the entity type (known = exposed in hook_entity_info())

Isn't that what we're testing?

Ooops, crosspost, my comment was for patch #4.

RTBC :-)

Small change to the assertion messages, no functional change so leaving RTBC.

Thanks!

Committed/pushed to 8.x, moving to 7.x for backport.

Rerolled patch from #10 for D7.

I've also included p0 format patch for the benefit of those not using a git checkout of core.

Moving to 'needs review'.

Good call, though I don't believe it's possible to specify that -p1 flag with drush make

But will they apply to a project that's not checked out from the git repo?

EDIT: Just tested that myself, and color me surprised.. it sure does. Thanks for the info on that Randy, I had no idea drush make would apply a git patch to a project that's downloaded rather than cloned from the repo. :)

At any rate, the patch in #14 does apply cleanly and resolves this issue.

I don't seem to be able to run the tests locally at all without them simply timing out and failing. Probably a server config issue I imagine, but I'm not clear why the one test is failing with the testbot, that shouldn't be affected by this patch at all as far as I can tell.

Queuing for re-test.

#14: field_info_instances_fix_returns-1245332-14-7.x.patch queued for re-testing.

Re-uploading D7 patch only.

I have tested #24 and I can confirm that it seems to resolve the issue, thank you!

Feel free to mark this issue as 'reviewed and tested by the community' then so we can get this fixed in Drupal 7. :)

yup, same as for D8

Weird. Why did it pass when you uploaded it?

Bumping to d8 because it needs to go in there first

My bad

Committed and pushed to 7.x. Thanks!

FYI I did a fresh install of D7.12 and some modules. I deleted all content types and then got this message:

The content type Basic page has been deleted.
Error message

    Notice: Undefined index: comment in field_info_instances() (line 687 of ../domain/modules/field/field.info.inc).
    Notice: Undefined index: node in field_info_instances() (line 687 of ../domain/modules/field/field.info.inc).

    Add content type

Name	Operations
No content types available. Add content type.

I installed the patch in #24 and the error messages disappeared after the cache was cleared. So that worked, thanks :)

it works for me too

Did this ever make it to a stable release? I don't see a note anywhere