If you view the release notes / release node for a project, there is no theming applied - it's just an ugly white background. At least on my sites anyway. This is because drupal_add_css() is being called within hook_nodeapi(), which I think causes caching issues.
Instead, drupal_add_css(drupal_get_path('module', 'fserver') . '/fserver.css'); should be placed in hook_init(). Yes, this will add it to every page, causing a minor amount of css 'bloat', but it's the only valid way to add CSS in D6.
If you agree, I can roll a patch for this.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | fserver-1245420-6.patch | 660 bytes | danepowell |
| #5 | patch-1245420.patch | 588 bytes | john bickar |
Comments
Comment #1
eugenmayer commentedconfirming this issue, just the same for me. But iam not very sure about your approach, nodeapi is wrong, but hook_init is even more wrong. Actually preprocess for the template would be the right place .. so theme_alter
Comment #2
danepowell commentedWhatever works sounds good to me :)
Comment #3
eugenmayer commentedSame here :)
Comment #4
john bickar commentedThe code in fserver.css has extra opening curly braces on lines 4 and 5, which is actually what is causing aggregated CSS to break.
Will see if I can provide a patch.
Comment #5
john bickar commentedLet's try this patch.
Comment #6
danepowell commentedThanks, that was a simple fix! Here's a proper Git-formatted patch.
Comment #7
danepowell commentedComment #8
eugenmayer commentedthanks guys, very helpful!
Comment #9
eugenmayer commentedapplied in ada518a for 6.x-1.2
moving to 7.x
Comment #10
eugenmayer commentedfor now, postponing all all D7 issues, as the branch seems unmaintained by the initial author. PLease suggest using D6 rather for now