When the "Recent content" block is placed on the page (e.g. in the footer or in a side column), the block shows empty squares where users with the permissions to modify the content would see "edit" and "delete" links. See attached screenshot for an example.
Those squares are useless for anonymous users (and all users that don't have the according permissions) and look confusing. They also take up some important space.
It would be nice if the squares that are supposed to hold the links would not be shown for users that cannot act on the content (other than by viewing it).
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | 1245446-16.patch | 3 KB | aerozeppelin |
| #16 | interdiff-1245446-6-16.txt | 2.18 KB | aerozeppelin |
| #16 | test-only-fail-1245446-16.patch | 1.61 KB | aerozeppelin |
| #9 | recent-content-before.png | 5.33 KB | David_Rothstein |
| #9 | recent-content-after.png | 5.3 KB | David_Rothstein |
Comments
Comment #1
tsi commentedThanks for reporting, but this is not a Dartik's issue, the same will happen with Bartik or any other theme.
This is caused by theme_node_recent_block (from core's node.module) that outputs a table without checking if the cells have content in them.
I would argue that using a table is wrong for this list but that is a different story.
Comment #2
drupal_was_my_past commentedCreated a patch that only renders edit and delete cells if the user has the appropriate access.
Comment #3
pooja.sarvaiye commentedThe patch code complies with Drupal coding standards.
The patch solves the issue by not showing the edit and delete cells, in case a user does not have permission to edit and delete.
Comment #4
dries commentedCommitted. Thanks!
Comment #5
dries commentedMoving to D7, actually.
Comment #6
avr commentedRerolled for Drupal 7.
Comment #7
dcam commented#6: drupal-1245446-6.patch queued for re-testing.
Comment #8
dcam commentedI tested #6. It works to correct the issue described in the OP. Before and after screenshots are attached.
Before:
After:
Marking this as RTBC.
Comment #9
David_Rothstein commentedThis will actually make things worse in the case of a user who e.g. has permission to edit some content types but not others (see screenshots).
I think we need to add some 'colspan' logic here to fix it correctly?
Before patch:
After patch:
Comment #10
David_Rothstein commentedComment #11
xjm(Merging "node system" and "node.module" components for 8.x; disregard.)
Comment #12
dawehnerNot a topic for d8 anymore given that it will be a view.
Comment #13
mimes commentedI'd agree with David_Rothstein. After testing, the patch does work for Drupal 7 in that it will hide unnecessary empty squares for anonymous users and those without permission to edit/delete content, but it also causes unsightly, irregular areas in the table if a user has permission to edit/delete some things but not others.
It would be nice if rows spanned the entire table/multiple columns with colspan.
Comment #16
aerozeppelin commentedUpdates to patch as per #13.