Moderation form should not use altered view node

Hm, good catch! Does the same node object gets passed around everywhere, though? In that case, the node in menu_get_object() would be the same object as the node post- hook_view(). Is it possible that Panels is misbehaving here by removing the title from the node object instead of messing with a render array somewhere and setting '#access' => FALSE or '#printed' => TRUE or something?

I wonder if tests will run if I set this to "needs review"...

I'd also be inclined to say Panels might be doing the wrong thing by modifying the node object itself.

The docs for hook_node_view() says modules should be modifying $node->content, not the node itself.

I am also running into this issue and the patch did resolve the issue with missing $node->title but it looks like it has b0rked the moderation form when viewing a draft. the select options are absent, and it appears to happen in the following logic

 if ($my_revision->vid == $node->workbench_moderation['current']->vid
      && $next_states = workbench_moderation_states_next($my_revision->state, $user, $node->type)) {

which is from workbench_moderation_moderate_form(). if i change the logic to

if ($next_states = workbench_moderation_states_next($my_revision->state, $user, $node->type)) {

it works again, however i am not familiar enough with the inner workings of the module to know what this could break.

EDIT: it also looks like publish is not an option with the fix i described above

Subscribing

Subscribing
Just a quick note confirming that this is still an issue in v1.0

*edited*
Sorry, the patch didn't work. It is causing issues. As described above, the Moderation box is disappeared.

Changing to 'needs work' because of the reported problems.

I wonder if we could get around this in another way. The problem phrased another way is that workbench_moderation_moderate_form_submit() can't trust the node object it is given. Does it need to be given a node object? What if workbench_moderation_moderate_form_submit() only had to trust a given nid/vid and loaded a node object from those and then called workbench_moderation_moderate_access() and workbench_moderation_moderate()?

Based on stevector's suggestion. Give this a try.

Bumping priority of this for an actual fix, this is a pretty significant issue for anyone using workbench + panels.

We can work around this for now by removing the block, but we'd love to see what the approved solution is going to be.

jerdavis, have you tried the patch in #13?

I tried the patch from #13, and can confirm that it works and solves the problem. Any chance to see this committed and released? I always feel a bit uncomfortable running on patched modules ;)

RTBC++

I have tested #13 and it works for me too. Thanks!

It would be great if this was committed soon.

Updated module to 7.x-1.2 and tested again. Still works.

I am having this problem too, but with the link module and no panels. The patch in #13 fixes my problem too.

Changing the moderation state of a node should not update any records except those that relate to storing the moderation state.

The patch from #13 applies to 1.2 with a little fuzz and seems to do the trick for me.

Here is a re-rolled version against 1.2.

I am rerolling this. @nrambeck & @matthew.donaido please read Advance patch contributor guide when you contribute a patch. This allows for good bug tracking for large projects.

Patch naming conventions explained

The (unofficial) patch naming convention that has emerged from the community is:

[description]-[issue-number]-[comment-number].patch

Reroll.

This is a similar problem with a similar solution: #1737048: 2 URL aliases created when saving new node as published

Thanks everybody: http://drupalcode.org/project/workbench_moderation.git/commitdiff/d0b0e7...