Some of this may be personal taste, but I found it useful to display more information on the discount code management page (/admin/settings/civievent_discount). This patch does two main things:

  • Adds a pager and sorter to the table
  • Adds organization, expiration columns and breaks out the description column (to enable sorting)

Issues: The expiration date if left blank will show a nonsense date. Not sure best way to have it show a blank entry. Also it would be nice to do sorting on organization but it's not possible unless the org name is in the original sql. It's not critical since a Views table can sort by org, etc.

Nice to have: a way to separate out expired discount codes into a separate table. This is how I've structured it in a View but would be good for default table to also have this. May leave it be given the MIH program with CiviCRM.

CommentFileSizeAuthor
improve-admin-table.patch4.39 KBnubeli

Comments

dharmatech’s picture

Assigned: Unassigned » dharmatech

Thanks for all of your patches and comments nubeli, you've made great contributions back to this module. I hope to take a look at these over the next few days and incorporate your suggestions and knock out some of the other issues in the queue.

dharmatech’s picture

Status: Needs review » Fixed

Thanks again @nubeli. I incorporated your changes and also fixed a bug where it wasn't displaying the amount in the admin table if it wasn't tied to an event. Fixed in latest -dev release. You may need to wait 24 hours for the next release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.