Original issue:

Posted by serkan_isin on August 10, 2011 at 11:18pm

I use automodal in my site and i would like to use feedback with that. Any chance any one ever tried?

Final solution:

Posted by rump on August 11, 2011 at 5:17pm

Final solution to those looking to implement this.
Update feedback_simple to at least version 6.x-1.2 and then download and enable the module from #4 OR provide the preprocess from #3 in your module or theme.

Comments

seandunaway’s picture

Hmm. As of right now feedback_simple does not support this, but this is a great idea. I'll add class support right now.

seandunaway’s picture

StatusFileSize
new1.27 KB

Here's a quick patch to add this functionality...

To enable this for automodal you could either a) Set the Automodal CSS selector to 'feedback_simple' at admin/settings/automodal or b) Hook into the theme layer.

seandunaway’s picture

Here is how you could hook into the theme layer. Add this to your custom module or theme:


/**
 * Implements hook_preprocess_feedback_simple().
 */
function MYMODULEORTHEME_preprocess_feedback_simple(&$variables) {
  // Add .automodal class.
  $variables['class'][] = 'automodal';
}

seandunaway’s picture

Version: 6.x-1.x-dev » 6.x-1.1
Assigned: seandunaway » Unassigned
Status: Closed (fixed) » Active
StatusFileSize
new913 bytes

Alternatively,

Just download this module and enable it. :)

seandunaway’s picture

Issue summary: View changes

Issue summary.

seandunaway’s picture

Version: 7.x-1.x-dev » 6.x-1.1
Assigned: seandunaway » Unassigned

After some limited testing it is working as desired except the issue of the Feedback tab showing up in the modal. I've created a separate issue for this at: #1246994: Hide the tab when on the $link page.

[6.x-1.x 334cf04] Issue 1245908 by rump: Add class support.
2 files changed, 8 insertions(+), 0 deletions(-)

Committed to dev.
Please re-open if any issues.

seandunaway’s picture

Version: 6.x-1.1 » 7.x-1.x-dev
Assigned: Unassigned » seandunaway

Forward-port this to 7.x-1.x.

seandunaway’s picture

Version: 6.x-1.1 » 7.x-1.x-dev
Assigned: Unassigned » seandunaway

[7.x-1.x 03283b9] Issue 1245908 by rump: Add class support.
2 files changed, 3 insertions(+), 1 deletions(-)

seandunaway’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Active » Closed (fixed)

Please re-open if any issues.

seandunaway’s picture

Final solution to those looking to implement this.

Update feedback_simple to at least version 6.x-1.2 and then download and enable the module from #4 OR provide the preprocess from #3 in your module or theme.

Status: Active » Closed (fixed)