Hi,

it would be nice to migrate not only group ids but also group names similar to the taxonomy handler.

CommentFileSizeAuthor
migrate_extras_og.patch2.73 KBjantimon

Comments

drewish’s picture

drewish commented
Status: Needs review » Needs work

I'm not a fan of the additional whitespace that was added.

I think the class should have some documentation added that they can use between looking up the group by name or did by setting the argument. I'm marking this as needs work because you changed the default from looking up by gid to looking up by name. That would break existing migrations. Oh you should also document that the state and created values can be passed in as arguments too.

What do you think about making getGidByName($name) a static function? It doesn't seem like it needs to be part of a class instance. There's some missing whitespace at if(is_null that should be fixed.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs work » Closed (won't fix)

Migration support for OG is now builtin to OG, any issues with that support should be raised in the OG issue queue.