Adding product kit to admin created orders several issues

Thanks for the detailed description. There is a bug somewhere in product kit handling, it just needs to be tracked down...

#1404636: Product kit attribute options not saved correctly from order edit form touched a similar issue which I think has the same cause:

@longwave: [...] the kit is shown unexploded immediately after adding it, but then if you refresh the page the exploded products show up correctly.
@wodenx: It's a bit more complicated to fix, though I think it's possible by moving uc_product_kit_uc_order_product_alter() functionality into hook_uc_order('presave', ...).

I was asked to look into this and I think I have come up with a fix, attached is a patched.

I added some special handling to product kits in the admin order side of things when adding products as well as changing one small bit on stock adjustment when the product was removed so that it properly logs the action (before it was being updated but without log).

I am also refreshing the order admin comments to show the stock updates (or any other log message that might have happened if the ajax module is used).

I wonder if this fixes some other issues in the queue. Anyway, tests as always appreciated.

I found further issues related to admin side of product kits. I noticed that the code added for attributes to work, probably in the referenced issue above, was missing some data so other callbacks works.

The way it was done, the sub products were all being saved as 'product' instead of their specified product type. This caused a lot of issues, but the one that prompt me to debug this was that tax was being applied to all products but a lot of them were of a different non-taxed product class.

This is tricky and probably kind of badly ported from D6, so I added a fix that works at least for saving the product type properly. It only adds the nid to the subproducts form elements that is expected on the add_to_cart_data callback from the products module. As all of this was mainly specific to product_kit I believe the fix (although maybe not covering 100% of the issues) it's definitely an improvement over the current codebase.

I took the time to write an extended comment referencing to this issue and explaining what all of that is about.

Also I spotted one tiny issue in the previous patch about admin comments ajax refresh, which is sorted now as well.

Re-rolled against latest dev, #6 applies anyway but to keep it up to date.

@hanoii: Can you split the admin comments Ajax issue out into a separate thread?

+  // Remove the field so we only refresh the admin comments item-list.
+  unset($form['admin_comment_field']);
+  $commands[] = ajax_command_replace('#order-pane-admin_comments .item-list', uc_order_pane_admin_comments('edit-theme', $form['#order'], $form, $form_state));
+

I don't know what this bug is and it doesn't look at all relevant to product kits.

I could and is not really related to product kit issues, but is relatively simple that it would be almost a pity not to include it.

I actually spotted it because when adding the product kits I wasn't seeing the stock decrement messages and then I realized they were there, only not visible when added.

I will quickly explain it here and if you think is best to do it on a separate issue I'll copy it over:

Basically when you update things via ajax on the form, a bunch of elements get refreshed, product table, totals etc. Everything except the admin comments, so you miss comments created, say by stock decrementing. That bit of code only refresh the admin comment list, so it should hardly do any harm. The unsetting is only not keep styling properly as I am only want to refresh the item list, so I remove the field not to get it rendered.

Yes let's have that in a separate issue, it's only a quick fix but it should be tracked separately.

Ok, attached patched without the ajax comment thing.

comments bit submitted to #2119541: admin comments do not refresh on order edit ajax calls

again trying to push this one for review. Sorry about recent comments but as I upgraded ubercart I went over all of my patches manually so taking the time to promote them a bit more.