Standardizing: please, write an uninstaller

I can definitely do that, but I have a question: removing all my tables and settings will potentially orphan many events. Additionally, once event_repeat_nodes is gone, all these nodes will never have a way to be references as a set, meaning you can't delete the whole group.

Would it be better for me to:
1. Put the installer in place, but not worry about the database tables?
2. Delete all repeating events (this has the potential of killing a server.)

Since this module will either be retired, or rewritten to no long use nodes as instances of repeating events, I'm leaning towards the first option, but I understand the usability issue.

Advice is welcome. (and thanks for the heads up)

I took another pass at the uninstaller, thinking this would help testing the upcoming changes. I think I get it now. I was thinking that uninstall happens at the point of disabling a module, which is where my comments above were coming from. Now I understand that uninstalling is a way to clean out the module after disabling it. My apologies for the confusion. Here is a patch.

I always like to include a watchdog entry as well, and usually identify the user doing the unistall. I do the same in the install.

Otherwise, looks good.

I'll roll up a new version with the watchdog entry that identifies the user.

I've added the uninstaller and modified feedback feedback for the install hook. Committed for both 5.x-1.x and 5.x-2.x.