Domain needs a domain record with ID=0.
The same issue is also known from anonymous user with ID=0.

There are some migration tools that destroy data integrity because inserting an undefined (NULL) record leads to creation of an autoincrement index.
Thus there's some risk that the default domain gets an arbitrary next autoincrement value and default domain with ID=0 is missing.

Missing default domain leads to complete misbehaviour and especially redirection loops on settings forms like
/admin/structure/domain/edit/$ID

I suggest to add a hook_requirements to check if the record exists.

Do you support this?

CommentFileSizeAuthor
#6 domain-update.png11.18 KBagentrickard
#6 domain-update-form.png21.78 KBagentrickard
#5 1247278-zero-id.patch11.83 KBagentrickard
#4 1247278-zero-id.patch6.97 KBagentrickard
#2 1247278-zero-id.patch5.94 KBagentrickard

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Yes. We also need this for 7.x.3, which does away with domain 0 and needs to check that the update ran properly.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 1247278-zero-id.patch5.94 KB

Patch for 7.x.3 requirements. We need something different for 7.x.2.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs work

Needs a test and a drush command.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 1247278-zero-id.patch6.97 KB

And the patch with a drush command (domain-repair).

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs work » Patch (to be ported)
StatusFileSize
new 1247278-zero-id.patch11.83 KB

Here's a working patch (with drush and tests) that can be used for a stable upgrade process. It has been committed.

Needs a rewrite for the 7.x.2 branch, if we want the original feature.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new domain-update-form.png21.78 KB
new domain-update.png11.18 KB

Screenshots for use in docs.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

Very nice progress.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

It's not quite the same issue, but this technique can be used in 7.x.2 as well.

The original issue is not applicable to 7.x.3.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Issue summary: View changes
Status: Patch (to be ported) » Fixed

Here's a working patch (with drush and tests) that can be used for a stable upgrade process. It has been committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.