Per suggestion from chx in #drupal, this pulls out the comment.module changes from chx's menu patch (http://drupal.org/node/122876) so that comments work in HEAD again. I fixed 5 E_ALL notices in comment.module while I was at it.

CommentFileSizeAuthor
#2 comment_head_0.patch5.71 KBChrisKennedy
comment_head.patch5.71 KBChrisKennedy

Comments

chx’s picture

chx commented
Status: Needs review » Needs work

again, again and again, isset vs empty are not the same. When you see if ($foo['bar']) it needs analysis whether if (isset($foo['bar'])) is the same, but if (!empty($foo['bar'])) is always the same, and equal speed. What's so hard in this?

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs work » Needs review
StatusFileSize
new comment_head_0.patch5.71 KB

Who says I didn't analyze it? Whatever, re-rolled.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks a lot Chris! :)

ChrisKennedy’s picture

ChrisKennedy commented

No problem, although I should emphasize that chx wrote 99.99% of the patch.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)