When implementing hook_domainconf(), it eventually adds a "settings" link to the default domain. This link goes to a special form domain_conf_default(). But in D7, the drupal_get_form invocation apparently changed, because I can see:
* Notice : Undefined index: sitename in domain_conf_default() (line 130 in domain/domain_conf/domain_conf.admin.inc).
* Notice : Undefined index: domain_id dans domain_conf_default() (line 143 in domain/domain_conf/domain_conf.admin.inc)..
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1247452-domain-conf-form-state.patch | 1.52 KB | agentrickard |
| #1 | domain_1247452_7.x-2.x.patch | 648 bytes | simon georges |
Comments
Comment #1
simon georges commentedPlease find the patch attached for 7.x-2.x-dev.
Comment #2
simon georges commentedAdditionnal notes :
- the #default_value is not set, because the part with the call to
$extra = domain_conf_api();does not contain a $settings part (relative to the similar call for domains other than default), I'll try to provide a patch for this part as well later (but the patch above is useless if it doesn't allow to see the current value, actually :().- the code is not the same in 7.x-3.x, settings values is discouraged for default domain, so the logic has changed for this part.
Comment #3
agentrickardLet's fix this in 7.x.3 and then backport.
Comment #4
agentrickardBug does not exist in 7.x.3, since that function was removed.
Comment #5
agentrickardMissed some other places where &$form_state needs to be passed by reference.
Comment #6
agentrickardSee #1251342: hook_domainconf() does not set #default_value for the other issue.
Comment #7
agentrickardNope, still fixed.