We're adding the External Links module to Drupal Gardens at Acquia. This patch includes some touch-ups to language and the configuration form based on feedback from our UX folks. We could implement this all with form_alters, but it seems like other people might like this fine-tuning too.

- Add more detail to .info file for module description.
- Tighten up language on config page.
- Get rid of icons on config page (this will be confusing for people who change the icon).
- Make pop-up warning text area conditional, based on the checkbox that enables pop-ups.

CommentFileSizeAuthor
#8 extlink-d6-1247644-1.patch3.93 KBelachlan
#5 extlink-1247644-5.patch3.89 KBelachlan
#4 1247644-language-and-ui-edits-4.patch3.95 KBmstef
#1 1247644-language-and-ui-edits.patch3.94 KBbryanhirsch

Comments

bryanhirsch’s picture

bryanhirsch commented
StatusFileSize
new 1247644-language-and-ui-edits.patch3.94 KB
quicksketch’s picture

quicksketch
he/him
commented

These look pretty good but I'd prefer to keep the icons in the description text, but that's actually been a problem in #963374: Use sprite for icons, so removing them would unblock that issue... I'll have to weigh them together.

bryanhirsch’s picture

bryanhirsch commented

Ok. Thanks for considering it.

mstef’s picture

mstef commented
StatusFileSize
new 1247644-language-and-ui-edits-4.patch3.95 KB

Rerolled to apply to 7.x-1.12.

elachlan’s picture

elachlan commented
StatusFileSize
new extlink-1247644-5.patch3.89 KB

Re-rolled the patch. Did not remove the images as per #2.

elachlan’s picture

elachlan commented
Status: Needs review » Patch (to be ported)

Committed to git. It will need to be ported to 6.x and 8.x.

elachlan’s picture

elachlan commented
Version: 7.x-1.12 » 6.x-1.x-dev

Just changing it to be 6.x port only. I have changed 8.x.

elachlan’s picture

elachlan commented
Status: Patch (to be ported) » Closed (fixed)
StatusFileSize
new extlink-d6-1247644-1.patch3.93 KB

Committed to Git.