Problem/Motivation

Currently patches are tested against the version number selected for a particular issue. Hence, if the issue node addresses a D7 bug, an attached patch will be automatically tested against the D7 simpletest suite of tests. Similarly, if the version number is changed to D8, it will be automatically tested against the D8 test suite. The rules for automatic testing are described in Automated patch testing (qa.drupal.org).

On or about November 1st 2011, issue #22336: Move all core Drupal files under a /core folder to improve usability and upgrades will be committed. This will change the file structure of D8 core and hence virtually all code changes to fix D7 bugs will require separate and distinct patches for D7 and D8. This will complicate the resolution of virtually all D7 bugs after that date as two patches will become required (one for D7 and one for D8).

Proposed resolution

My suggestion is that we change the automatic patch testing process so that a test suite version number can be specified for a particular patch. By default, a patch would continue to be tested against whatever version the issue was set to. However, two patches could be attached for say D7 and D8 versions and they would be automatically tested against their respective test suites. Such an option will speed up the resolution of D7 bugs since D7 and D8 patches can be developed and tested simultaneously (where the code logic is much the same but the file structures differ).

Remaining tasks

TBD

User interface changes

TBD

API changes

TBD

Original report by [username]

// Text of original report here.
(for legacy issues whose initial post was not the issue summary)

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Project: Drupal core » Test driven development infrastructure
Version: 8.x-dev »
Component: simpletest.module » Code

This would be pretty useful. Moving to TDD as this is a feature request for testbot and not the module itself.

jthorson’s picture

jthorson commented
Project: Test driven development infrastructure » Drupal.org Testbots

Moving over from abandoned testing infra issue queue.

isntall’s picture

isntall commented
Project: Drupal.org Testbots » DrupalCI: Drupal.org Testing Infrastructure
Issue summary: View changes
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Project: DrupalCI: Drupal.org Testing Infrastructure » DrupalCI: Test Runner
Component: Code » Codebase Build
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Project: DrupalCI: Test Runner » Project issue file test
Version: » 7.x-3.x-dev
Component: Codebase Build » Code
Status: Active » Postponed (maintainer needs more info)

I don't think this is relevant anymore - I don't think we want to embed the version number of a patch into the patch vs into the issue (though semantically/data model perspective thats much nicer).

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Component: Code » Testing Triggers
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Postponed (maintainer needs more info) » Fixed

Or maybe Im wrong and this is already done: #1171958: Allow files to be assigned to branch(es)/version(s) and thus tested against it

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.