I was working on a module that needed to override the default node/add access for a specific content type. I added my own access callback for this content type using hook_menu_alter, but noticed it wasn't be fired. If I changed the weight to my module to 1, it worked correctly.

I started investigating and found that nodecomment module adding it's own node access function "_nodecomment_node_add_access" to every content type for the path node/add/[content-type]. After reading thru your modules implementation a bit, I think the intention was to just add the custom callback for node types that utilize nodecomments for comments, NOT for every content type instead.

I patched this to only add the access callback "_nodecomment_node_add_access" for the proper content types.

CommentFileSizeAuthor
#1 menu_alter_fix-1249196.patch1.08 KBbkosborne

Comments

bkosborne’s picture

StatusFileSize
new1.08 KB
broncomania’s picture

Oh man thx for your patch! This solve my problem http://drupal.org/node/1053816 with the Missing argument 2 for _nodecomment_node_add_access() in nodecomment.module and should really be commited. I have also created own content types. They get broken without this patch!

crea’s picture

Status: Active » Closed (won't fix)

2.x is unlikely to get any support at this point. Closing all related issues.