Getting the error below when saving configurations for this module and the Views module is not installed. Views is not listed as a dependency, but maybe it should? Atleast, a check to see if the module is installed should be added to the html5_tools_admin_settings_submit() function in html5_tools.admin.inc.

Notice: Undefined index: html5_tools_override_views_field_rewrite_elements in html5_tools_admin_settings_submit() (line 120 of sites/all/modules/html5_tools/html5_tools.admin.inc).
CommentFileSizeAuthor
#2 1249642-undefined-index.patch1.91 KBbleen

Comments

ericduran’s picture

ericduran commented

Views module is not a requirement. This is just a bug in the code. I'll fix this later.

Thanks for the bug report.

bleen’s picture

bleen commented
Status: Active » Closed (fixed)
StatusFileSize
new 1249642-undefined-index.patch1.91 KB

committed this patch to dev

ericduran’s picture

ericduran commented

I changed the patch around a bit. Since we're already doing a module_exist on the form, we can simplify having two if statements on the submission by using empty instead.

I committed it over at http://drupalcode.org/project/html5_tools.git/commit/b946b265a023767c1dd...

:-)