Closed (won't fix)
Project:
Leech
Version:
4.7.x-1.6
Component:
leech_news
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
5 Mar 2007 at 22:53 UTC
Updated:
2 Jan 2008 at 19:39 UTC
Jump to comment: Most recent file
My site has ~100 feeds to leech. Most of them have a retention period of 2 weeks.
Old items are simply not being deleted. Nothing is has been deleted for more than a month. I have no idea why. Any ideas?
The problem is quite urgent, my database is growing very quickly.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | feedapi-per-feed-delete-interval.png | 19.37 KB | aron novak |
Comments
Comment #1
aron novakThanks for reporting this!
Actually this feature was simply not implemented. You can find the fix at the CVS.
You can patch your file according this: http://cvs.drupal.org/viewcvs/drupal/contributions/modules/leech/leech.m...
Comment #2
zis commentedThx.
I'll test it soon.
Perhaps it would be better to aka the table names in the query. Check the snippet below.
Comment #3
aron novakThanks for this advice!
I changed this part of the code, it's really much nicer :)
Have you tested it? Any experience?
Comment #4
zis commentedI tested it, and it is working allright.
But, i think it would be better to check for old items for each feed at a time rather than checking the whole database at once. This way, after a feed is refreshed, only that feed is checked for old items..
Because I had a couple thousand old items, the script timmed out a couple of times before deleting them all.
One more thing, i can't seem to find a hook_delete function for feed items, i might have missed it though.
Comment #5
aron novakThanks for trying out the solution.
Yes, you mentioned that the script ran into timeout. But if this deletion-stuff would work okay nicely, it couldn't happened i think.
hook_delete: the node_delete does the job what you mentioned.
Comment #6
zis commentedI really think it should be set up to delete items on a per feed basis.
If a site aggregates 100 items/day, 1 cron run will have to delete 100 items in 1 time.. which is very time consuming..
if it is set to items on a per feed basis, the 100 items will spread to multiple runs..
Comment #7
aron novakUnfortunately now I don't have time to implement your suggestion (the suggestion is good) about the per feed basis deletion. If you implement it, I'm glad if you can send a patch :) Ask me if any help is needed you to do this.
Comment #8
aron novakI would like to suggest you FeedAPI, there this feature is implemented already. Let's look at the attached screenshot.