Posted by bcn on August 16, 2011 at 8:54am
4 followers
Jump to:
| Project: | Quick Tabs |
| Version: | 6.x-3.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Not sure if this a bug or feature (ie intended), but I don't see how you can alter quicktabs if they're coming from code... Only quicktabs coming from the database were available via hook_quicktabs_alter.
Attached patch allows for altering of quicktabs that are stored in code.
| Attachment | Size |
|---|---|
| quicktabs-drupal-alter.6.3.patch | 1.42 KB |
Comments
#1
Thanks for the patch @noahb - I hope to get to this in the next couple of days. I know that I fixed this in D7 and actually ended up totally changing where drupal_alter gets called, because it didn't make sense to be calling it right when the QT instance was being pull from code / the db - that means that you see the altered version in the admin form, which doesn't make sense. It should get called when the instance is being displayed.
So I'm setting to needs work as I want to make sure the solution is the same as the D7 one.
#2
Sorry for the delay on this. I've committed a fix that's more in line wiht the D7 version, i.e. it puts the call to drupal_alter in the render function. See http://drupalcode.org/project/quicktabs.git/commit/382862e
#3
Automatically closed -- issue fixed for 2 weeks with no activity.
#4
@katbailey, judging from the commit this would ensure that the alter works regardless of whether CTools are enabled right? I'm using 6.x-3.0 so the commit isn't in there yet but I noticed that if I have CTools, there's a no go on the alter. That sound about right? Thanks!