Commerce payment by invoice

Just tagging.

Hi jsacksick,

Commerce projects often take a long time to be approved because few people know enough about Commerce yet to do reviews. I'd encourage you to go where people are talking about Commerce and encourage them to come here and help review your project. Some places you might ask for reviews:

http://groups.drupal.org/drupal-commerce
http://www.drupalcommerce.org/forum
The #drupal-commerce IRC channel

• git release branch missing, see http://drupal.org/node/1015226
• README.txt is missing
• only list files in the info file that contain classes or interfaces
• I think commerce_payment already depends on commerce, so no need to add commerce as dependency again.
• "Implementation of hook_commerce_payment_method_info()." should be "Implements hook_commerce_payment_method_info()."
• module file: @file doc block is missing, see http://drupal.org/node/1354#files

jsacksick,

A quick search on Drupal.org turned up the following modules:

• Commerce Invoice
• Commerce PDF Invoice
• Commerce Invoice Receipt

There are also other implementation options posted in #1214592: Support for HTML invoices and #1076142: Add an "invoice" view mode.

Given the above, can you provide some feedback as to whether your module provides some functionality over and above the existing solutions, and would you consider partnering with those maintainers as opposed to introducing yet another option? (Eventually, module duplication just leads to end user confusion as they are forced to pick between multiple modules which appear to do the same thing.)

He's talking about an option to let users "pay by invoice" during checkout, which is a different payment method. The Commerce Invoice modules you mention have to do with the actual invoice Commerce generates, not a payment method.

I think this option should indeed exist.
If you are a customer known to the store (eg a company), this payment method can be enabled.

After "payment", the order can be processed as an invoice in the back end.
One question however, will this set the balance to 0, or ignore the balance alltogether?

Thanks for the follow up.

Tagging back for review

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review :

Just to let you know that I tested you module and it worked. I will use it but need to find a way to save the invoice number somewhere.

if the module is going to be "commerce_payment_by_invoice" you should rename all the files accordingly. Now they are all commerce_payment_invoice.*

First some nitpicking:

> description = Add the payment by invoice method

Should be in the form 'Provides a payment by invoice method.' -- with a final full stop.

> * @return void

There's no need to say this. Though note that a @return needs a blank line above it.

> * @return array

Unless this is array has a standard structure documented elsewhere, you should say what's in it. In this case, something like 'An array suitable for FormAPI #options.' would do.

> if the module is going to be "commerce_payment_by_invoice" you should rename all the files accordingly. Now they are all commerce_payment_invoice.*

commerce_payment_invoice is probably a better machine name.

The label shown in the UI on the checkout form doesn't read very well: 'Payment by invoice'. Can the admin label and the checkout label be different? 'Pay by invoice' would be better at least.

A bit more complex: I'm not sure what your use case is. As the previous comment says, some use cases will need to store the invoice number in the order. My own use case requires users to enter an account number which should be validated before this payment method is accepted. I can imagine a use case where access to this payment method is restricted by role. However, all these matters can wait until after this sandbox moves to full project.

I also note that the last review was February 28, 2012, 4 months ago. Is the author of this still interested in pursuing this application? If it's abandoned, I'd very much like to take it on myself :)

Thanks!

Are you still pursuing this project application?
If so, I probably shouldn't make commits to the project until that's successful, as that's what's being reviewed.

I am also interested in this module. Please say something if it is going to be a proper module.
Sorry I can't help, my php level is not enough.
Thanks for the work!

This would be a very useful module. Is anybody still working on it?

It sounds like jsacksick has no current plans to complete this application, so I'm marking it as closed. If that changes, please update the status.

There's obviously a lot of people interested in this code and it becoming a full project, so I'm not sure that's the best thing to do.

joachim, you're a maintainer on the project and you have full project access, so you could make it a full project regardless of this application. But there's no way for jsacksick's application to move forward without jsacksick working on it, which he has twice stated he isn't doing. Again, if that changes, please update the status.

Ah right. In which case, we'd need jsacksick to grant access so some of the other people interested in taking this project forward.

I'm also very interested in this becoming a full project, I've never maintained a project here on d.o., though.

I don't think we need this module as this usecase is already solved with Payment module.

It has a 'Basic Payment Method' with which you can create a 'Pay by invoice' payment method.
You can set its 'Final Payment Status' setting to 'Pending'.
And you can name it whatever you like, show extra information to the user etc.

Documentation on how to do this can be found at http://drupal.org/node/1932450

An example of how that would look with Payment module:
(the italic message is optional, configurable, and supports text formats)

Thanks s1l for this

Payment module does solve the solution but you also had to install http://drupal.org/project/payment_commerce with the payment to complete the above task.