Needs work
Project:
Google Chart Tools: Image Charts
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
16 Aug 2011 at 15:43 UTC
Updated:
16 Nov 2014 at 17:53 UTC
Jump to comment: Most recent
Comments
Comment #1
13rac1 commentedDoesn't apply because patch expects files to already exist. Use git diff --cached and git add to make a patch with new files.
The tests need not be in a new module. Simply adding them to the main module, and views module will work.
There are two permissions being added, but I don't see either being used. They should probably be removed.
Please update patch to work against the 7.x-1.x-mk branch.
Thanks for your efforts!
Comment #2
Pierre.Vriens commentedMaulik, I know we're more then 3 years later, but still: thank you very much for this suggestion. I think it's extremely valuable, a pity it has been sitting in the issue queue for so long. Can you (or anybody else?) think of a way to provide an updated version of this patch, I"d assume a patch to be applied to the most current 7.x dev version. If the items in #1 could be addressed at the same time, that would be even better.
What I don't quite understand in #1 (yet), is the 2nd paragraph about new module: why? What are the pros/cons? It appears to me that if you can put it in a separated module, you can only enable that module whenever you really want to do testing. Am I missing something?
Comment #3
Pierre.Vriens commentedComment #4
Pierre.Vriens commented