While creating the first term_view page, I received the following error after saving the variant for the first time:
Strict warning: Creating default object from empty value in page_manager_http_response_admin_summary() (line 132 of sites/all/modules/contrib/ctools/page_manager/plugins/task_handlers/http_response.inc).

CommentFileSizeAuthor
#4 ctools-n1251474-4.patch1020 bytesdamienmckenna
#3 ctools-n1251474.patch642 bytesdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Project: Panels » Chaos Tool Suite (ctools)
Version: 7.x-3.x-dev » 7.x-1.x-dev

Sorry for missing the obvious, this is a CTools bug, not Panels.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The line in question is:

  $display->context = ctools_context_load_contexts($object, TRUE);

Oddly enough $display is not defined anywhere within that function? Should it have been, or should it be just an empty StdClass?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new ctools-n1251474.patch642 bytes

Goes this work?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new ctools-n1251474-4.patch1020 bytes

Alternatively, the D6 branch just does this:

  $context = ctools_context_load_contexts($object, TRUE);

Here's a patch to change to that variable usage.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

IMHO the patch from #4 would be the way to go, especially given it brings it more in line with the D6 branch.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Sensible. Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jimclegg’s picture

jimclegg commented
Version: 7.x-1.x-dev » 7.x-1.0-rc1
Status: Closed (fixed) » Reviewed & tested by the community

I copied from ctools-n1251474.patch the line $display = new stdClass(); into the file http_response.inc and it eliminated the Strict warning.

Is it necessary to run the patch to fix the error or is it ok to copy and paste the code into http_response.inc?

edbradburn’s picture

edbradburn commented

Sorry if this is not the correct response – I'm new to the Drupal Issues pages – but I still get this behaviour (i.e. I have the exact same error message) using

Chaos tool suite (ctools) 7.x-1.0-rc1

What is the appropriate action for me to take?

Patch what I have, wait for a new release, etc.?

It's not mission-critical, but I am unsure how the bug can be reported as fixed if it isn't, if you see what I mean.

Cheers,

Ed

merlinofchaos’s picture

merlinofchaos commented
Version: 7.x-1.0-rc1 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

It was committed to the repository and is in 7.x-1.x-dev -- however, 7.x-1.0-rc1 was released prior to the patch being committed. You'll either have to use -dev or wait for the next release. It's not too hard to check dates on releases to see that's the case.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.