Wrong placeholder in url
knseibert - March 6, 2007 - 10:23
| Project: | OG Roles |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
Hi,
just installed latest cvs version of og and og_roles.
When no custom roles are defined og_roles_settings displays a message refering to admin/access/roles.
It seems that the % placeholder causes the url to contain em-tags. Switching to @ placeholder fixes this problem.
Patch attached.
| Attachment | Size |
|---|---|
| og_roles_url_fix.txt | 963 bytes |
#1
Doh. Just noticed that it is the wrong url after all. Roles are now to be found under /admin/user/roles.
I have kept the placeholder name @access although it has not much to do with "access" anymore.
Anyway... patch attached.
#2
Now i have added some custom roles. The fieldset title html reads:
<legend><em><em>Group</em></em> role options</legend>Which looks like this:
<em>Group</em> role options
This is due to:
1) % placeholder iso @
2) theme('placeholder') function, which IMHO is not necessary here.
Again, patch attached.