Patch for address, structured message with tokens and better theming

Great patch eddib. I just added a seperator.

patch rerolled to match latest dev version - including:
- clean-up of empty lines formatting
- removed bugfix #1304086: payment method undefined which was already committed to dev version separately
- updating new data to also uses !empty() check instead of <> ''

what is in this patch? (needs mention since it is not following common drupal practice 1 fix per issue)
- configurable separator
- additional data field "Account address"
- additional data field "Message for bank transfer form"
- structured message field that can contain tokens (order, user, date)
- allow tokens in bank transfer message
- theme output with div and span

to do:
- IMO "Account address" is not necessary as international banking standard is to ignore this data anyway
- please explain why have "Message for bank transfer form" - how is this different from payment instructions?
- explain logic/code line 128 in patch (is this a bug?)
- untangle patch into separated issues so we can see interest and discussion for each one of them

Hey xibun!
Nice patch (althoug i had to patch it manually.. patch -i had problems with it)

Do you also have this notice at the checkout process after submitting?

Notice: Undefined index: payment_details in commerce_payment_pane_checkout_form_submit() 
(Line 190 of ..../all/modules/commerce/modules/payment/includes/commerce_payment.checkout_pane.inc).

cheers?

edit:

I could "solve" this Problem by adding:

$form['dummy'] = array(
  '#type' => 'hidden',
  '#value' => 'dummy'
  );

to the End of this function function commerce_bank_transfer_submit_form() over the return.. patch found here: http://drupal.org/node/1230666

As per the comment #3 I've started to break out some individual patches / issues based on this patch:

* Support for tokens - #1676822: Token support for payment instructions field
* Improved theme support (not based on the patch here, but instead allows the output to be more easily overridden) - #1998080: Use hook_theme to theme bank details