This is a pretty simple piece of functionality to add and saves users entering invalid emails which could cause errors in other places. Here's a patch that does it!

CommentFileSizeAuthor
#13 reroute_email.validate_email_addresses_1252762_13.patch3.04 KBrfay
#11 reroute_email.validate_email_addresses_1252762_11.patch4.02 KBrfay
#6 reroute_email.validate_email_addresses_1252762_05.patch1.87 KBrfay
#4 reroute_email.validate_email_addresses_1252762_04.patch1.64 KBrfay
reroute-email-validate.patch898 bytesacbramley

Comments

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
commented
Status: Active » Reviewed & tested by the community

Looks good to me, lets get this patch in

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Reviewed & tested by the community » Needs review
wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
commented

This patch is also relevant for the 6.x branch (and would be a nice addition)

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new reroute_email.validate_email_addresses_1252762_04.patch1.64 KB

Minor reroll. This seems like a reasonable addition.

It is annoying as I now have to reroute to rfay@localhost.localdomain, since valid_email_address() thinks that rfay@localhost isn't valid :-(

Status: Needs review » Needs work

The last submitted patch, reroute_email.validate_email_addresses_1252762_04.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.validate_email_addresses_1252762_05.patch1.87 KB

Not sure what happened there...

Status: Needs review » Needs work

The last submitted patch, reroute_email.validate_email_addresses_1252762_05.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Needs work » Needs review

Ah, I think it's trying to patch 7.x-1.0

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

#6: reroute_email.validate_email_addresses_1252762_05.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, reroute_email.validate_email_addresses_1252762_05.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email.validate_email_addresses_1252762_11.patch4.02 KB

Wow, taking me a while. This one allows the list of email addresses to be separated by commas and semicolons, and fixes the test.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Committed to 7.x-1.x: cb90523

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new reroute_email.validate_email_addresses_1252762_13.patch3.04 KB

Committed to 6.x-1.x in 00c590d, as attached.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.