Use of undefined constants when running install.php [#1252846]

If ThemeKey gets installed by the install profile then you get all those annoying warnings in dblog about undefined constants during installation all the time.

I am just wondering why you're not defining the constants at the top of themekey.module without any conditions? At least that's the case for almost all other modules and only themekey tries to define those constants only when really really needed - or even less often ;-)

Comment	File	Size	Author
#2	1252846.patch	2.63 KB	mkalkbrenner

Comments

Comment #1

mkalkbrenner

German

🇩🇪

commented 18 August 2011 at 07:55

I am just wondering why you're not defining the constants at the top of themekey.module without any conditions?

Good question. I can't remember where it was documented for Drupal 6 to define constants in hook_init(), but this was the reason for the current code base. Due to the fact that hook_init() is not called during installation we define the required constants at many places.

But it seems that defining the constants the natural way at the top of a file is best way and absolutely ok for D7.