The password addition process (when being at user/%d/edit/twitter) crashes because there is some missing logic from the 6.x branch which, on hook_submit, connects to Twitter.com, grabs account details (name, avatar, description, etc) and stores them at the twitter_accounts table.

The following patch fixes this. Once applied I could add an account by just providing the Twitter user name. I could later see my tweets at my account page (and in a block) by running cron.

Please review the following patch and consider applying it to the dev branch as soon as possible.

A step by step guide to add a twitter block with this module has been added at http://drupal.org/node/1253026.

CommentFileSizeAuthor
add_twitter_account_crashes.patch1.45 KBjuampynr

Comments

imiksu’s picture

imiksu
Location Finland
commented

I confirm the description and the patch fixes this issue.

I had two PHP notice errors after applying the patch and adding the username (without password):
Notice: Undefined index: oauth_token in TwitterUser->set_auth() (line 502 of .../sites/all/modules/twitter/twitter.lib.php).
Notice: Undefined index: oauth_token_secret in TwitterUser->set_auth() (line 503 of .../sites/all/modules/twitter/twitter.lib.php).

michaek’s picture

michaek commented
Status: Needs review » Closed (fixed)

Looks good to me. Just applied and pushed! http://drupalcode.org/project/twitter.git/commit/90b5d7f

michaek’s picture

michaek commented
Issue summary: View changes

Added reference to doc page with step by step guide.