Limit terms to single vocabulary not respected [#1253054]

It seems the latest dev release from panels is not respecting the vocabulary selection when creating a relation to use as context for e.g. views 3.

I found this problem while setting up a product catalog for DCommerce which in my case means a product display has a catalog term and general terms.

To reproduce create a content type with 2 term reference fields pointing to two different vocabularies.
Create nodes with terms in both vocabularies.
Create a panel to override the node display and add a relation for multiple terms related to the node, use only the second vocabulary and use the resulting tids as title output for the node.

Expected result: show only the tids from the specified vocabulary
Current result: shows the terms from both vocabularies

Comment	File	Size	Author
#5	ctools-limit-terms-to-vocab-1253054-5.patch	1.9 KB	fabsor
#4	ctools-limit-terms-to-vocab-1253054-4.patch	1.87 KB	BJ___
#3	restrict-vocabularies-1253054-3.patch	1.86 KB	markusbroman

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 18 August 2011 at 12:03

Component:

Plugins - arguments

» Plugins - relationships

Update to change the component arguments -> relationships

Comment #2

merlinofchaos CreditAttribution: merlinofchaos commented 2 December 2011 at 23:02

Project:	Panels	» Chaos Tool Suite (ctools)
Version:	7.x-3.x-dev	» 7.x-1.x-dev
Component:	Plugins - relationships	» Code

Hm. This would be a CTools thing, not Panels.

Comment #3

markusbroman CreditAttribution: markusbroman commented 5 March 2012 at 15:58

Status:

Active

» Needs review

File	Size
restrict-vocabularies-1253054-3.patch	1.86 KB

Patch created to solve this issue. Added a check to see if vocabularies are checked in $conf before adding the term to $terms array. Also changed from using vocabulary id to using vocabulary machine name as key in $options array.

Comment #4

BJ___ CreditAttribution: BJ___ commented 13 March 2012 at 15:15

File	Size
ctools-limit-terms-to-vocab-1253054-4.patch	1.87 KB

The previous patch causes an error. Here is a new patch that fixes that

Comment #5

fabsor CreditAttribution: fabsor commented 14 March 2012 at 12:27

File	Size
ctools-limit-terms-to-vocab-1253054-5.patch	1.9 KB

I think we need to check that $conf['vocabulary'] is set to avoid compatibility issues. This patch makes sure the old behavior will be preserved (no filtering per vocabulary) and we should avoid any notices that might otherwise occur.