can you please make the module for drupal 5?

CommentFileSizeAuthor
#14 delicious-5x.patch13.59 KBdouggreen
#9 delicious_5.patch25.52 KBax
#4 delicious_4.patch25.09 KBax
#3 delicious_2_0.patch10.38 KBax
#2 delicious_1.patch6.65 KBAnonymous (not verified)
#1 delicious_0.patch4.57 KBAnonymous (not verified)

Comments

Anonymous’s picture

StatusFileSize
new4.57 KB

would you please test this patch .

Anonymous’s picture

StatusFileSize
new6.65 KB

here is the complete patch , please provide feedback

ax’s picture

Status: Active » Needs work
StatusFileSize
new10.38 KB

made this actually work for 5.X:

* provided info-file - without this, module cannot be enabled
* fixed form submission at user/<uid>/delicious
* made block links work
* made "smart tagging" work, with a big regexp instead of so many foreaches
* doc, coding-style, redundancy

this module needs more work. see TODO: in code, and just look at it.

ax’s picture

StatusFileSize
new25.09 KB

more fixes and enhancements, incl.

* support for private links (only show them to owning user)
* better recent bookmarks formatting
* better and tested api doc
* and more, which i forgot because its 3 month ago i did this

may someone find this useful.

derekvan’s picture

Hi,

I can't get this patch to work--many hunks fail. Any chance of getting it re-synced? Or maybe I'm doing it wrong? I executed this command:

patch delicious.module < delicious_4.patch

Thanks!

ax’s picture

you need to use patch -p0 < delicious_4.patch, see Applying patches in the Developing for Drupal handbook.

derekvan’s picture

thanks for the reply--I'm still having trouble after reading the guide. Here's what I'm doing:

navigating to: modules/my_modules/delcious
patch -p0 < delicious_4.patch

I didn't get any hunk failures this time. However, the delicious module doesn't show up in my list of modules, so I can't enable it. I tried deleting the delicious directory and starting over, by first applying the delicious_0.patch, and the the delicious_1.patch, but this also resulted in lots of errors.

Can you walk me through the process here? Thanks so much,
derek

ax’s picture

you only need delicious_4.patch. make sure there is only one delicious.module in your drupal install and only one entry for it in the system table and that its path is right. you are running drupal 5, right? check google. if you really cannot get it to work, pls contact me off site (axel AT kollmorgen DOT net , skype:akollm, icq:19144959).

ax’s picture

StatusFileSize
new25.52 KB

sorry, my wrong. delicious_4.patch misses the info-file from delicious_2_0.patch. here is a new one including everything needed - hope it will work now.

ax’s picture

further fixes, updates, and development in my sandbox

Anonymous’s picture

I have a corrected a few problems .

1. Updating delicious bookmarks was not working .
2. The number of delicious links for a given tag was not correct
3. A few other minor things

Please download the full delicous module from here

http://paulbooker.co.uk/?q=delicious-5.x-1.0-dev-RC2

for testing If i have time later i will generate a patch.

ax’s picture

paul - there is nothing to download at the link you provided. please submit patches here or to the Drupal contrib CVS repository. thanks!

Anonymous’s picture

Thanks Ax ,

I will upload the patch later today , you can now login with your drupal account on my site and download the module in the meantime if you wish .

Speak to you soon .

Paul

douggreen’s picture

StatusFileSize
new13.59 KB

I also have significant changes for a 5.x patch. Attached is my patch.

What we need to do is get CVS rights to this project and get them committed.

douggreen’s picture

Status: Needs work » Fixed

I just realized that I have enough rights on d.o to give myself CVS rights to the project, so I did, I created a new 5.x branch, applied my patch, and created a release. Earl is still looking for a project maintainer, and I'm not offering to do that. I simply pushed this project forward a little...

merlinofchaos’s picture

I found a project maintainer. It's just that the project maintainer is awol. Go figure.

I guess we need Yet Another Project Maintainer for this.

ax’s picture

Version: master » 5.x-1.x-dev

merlinofchaos: count me in as YAPM for this.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.