drupal 5.X

dereine - March 6, 2007 - 19:56
Project:Delicious
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

can you please make the module for drupal 5?

#1

paulbooker - April 2, 2007 - 22:23

would you please test this patch .

AttachmentSize
delicious_0.patch 4.57 KB

#2

paulbooker - April 3, 2007 - 10:01

here is the complete patch , please provide feedback

AttachmentSize
delicious_1.patch 6.65 KB

#3

ax - June 6, 2007 - 21:14
Status:active» needs work

made this actually work for 5.X:

* provided info-file - without this, module cannot be enabled
* fixed form submission at user/<uid>/delicious
* made block links work
* made "smart tagging" work, with a big regexp instead of so many foreaches
* doc, coding-style, redundancy

this module needs more work. see TODO: in code, and just look at it.

AttachmentSize
delicious_2_0.patch 10.38 KB

#4

ax - August 31, 2007 - 17:49

more fixes and enhancements, incl.

* support for private links (only show them to owning user)
* better recent bookmarks formatting
* better and tested api doc
* and more, which i forgot because its 3 month ago i did this

may someone find this useful.

AttachmentSize
delicious_4.patch 25.09 KB

#5

derekvan - September 30, 2007 - 14:53

Hi,

I can't get this patch to work--many hunks fail. Any chance of getting it re-synced? Or maybe I'm doing it wrong? I executed this command:

patch delicious.module < delicious_4.patch

Thanks!

#6

ax - September 30, 2007 - 15:45

you need to use patch -p0 < delicious_4.patch, see Applying patches in the Developing for Drupal handbook.

#7

derekvan - September 30, 2007 - 16:33

thanks for the reply--I'm still having trouble after reading the guide. Here's what I'm doing:

navigating to: modules/my_modules/delcious
patch -p0 < delicious_4.patch

I didn't get any hunk failures this time. However, the delicious module doesn't show up in my list of modules, so I can't enable it. I tried deleting the delicious directory and starting over, by first applying the delicious_0.patch, and the the delicious_1.patch, but this also resulted in lots of errors.

Can you walk me through the process here? Thanks so much,
derek

#8

ax - September 30, 2007 - 17:41

you only need delicious_4.patch. make sure there is only one delicious.module in your drupal install and only one entry for it in the system table and that its path is right. you are running drupal 5, right? check google. if you really cannot get it to work, pls contact me off site (axel AT kollmorgen DOT net , skype:akollm, icq:19144959).

#9

ax - September 30, 2007 - 19:09

sorry, my wrong. delicious_4.patch misses the info-file from delicious_2_0.patch. here is a new one including everything needed - hope it will work now.

AttachmentSize
delicious_5.patch 25.52 KB

#10

ax - September 30, 2007 - 22:23

further fixes, updates, and development in my sandbox

#11

paulbooker - October 31, 2007 - 13:21

I have a corrected a few problems .

1. Updating delicious bookmarks was not working .
2. The number of delicious links for a given tag was not correct
3. A few other minor things

Please download the full delicous module from here

http://paulbooker.co.uk/?q=delicious-5.x-1.0-dev-RC2

for testing If i have time later i will generate a patch.

#12

ax - October 31, 2007 - 13:44

paul - there is nothing to download at the link you provided. please submit patches here or to the Drupal contrib CVS repository. thanks!

#13

paulbooker - October 31, 2007 - 16:13

Thanks Ax ,

I will upload the patch later today , you can now login with your drupal account on my site and download the module in the meantime if you wish .

Speak to you soon .

Paul

#14

douggreen - November 1, 2007 - 17:06

I also have significant changes for a 5.x patch. Attached is my patch.

What we need to do is get CVS rights to this project and get them committed.

AttachmentSize
delicious-5x.patch 13.59 KB

#15

douggreen - November 1, 2007 - 17:24
Status:needs work» fixed

I just realized that I have enough rights on d.o to give myself CVS rights to the project, so I did, I created a new 5.x branch, applied my patch, and created a release. Earl is still looking for a project maintainer, and I'm not offering to do that. I simply pushed this project forward a little...

#16

merlinofchaos - November 1, 2007 - 17:29

I found a project maintainer. It's just that the project maintainer is awol. Go figure.

I guess we need Yet Another Project Maintainer for this.

#17

ax - November 2, 2007 - 03:29
Version:HEAD» 5.x-1.x-dev

merlinofchaos: count me in as YAPM for this.

#18

Anonymous - November 16, 2007 - 03:31
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.