Setting the 'Page Title' field to empty does not clear the title user entered title

Same problem here. Once i've typed something in, it's not possible to delete it later. I had to clear it in the page_title database table.

subscribing... same problem here

subscribe

please test

Code changes are successful, but patch had to be applied from Drupal's webroot rather than the module's folder. I'm not sure what the best practices are for that.

so lets set this to RTBC

Patch worked for me, had no problem patching from module directory either.

I tested Giorgos's patch, and it works correctly. I'm reuploading the patch with correct pathing.

It works for me.... RTBC....

It works for me.... RTBC....

It works for me too. Thankyou.

how do i use this patch in a live site ?

@Energyblazar,

Make sure to try this in a development environment before you do anything on a live site :)

To apply the patch:
Making and applying Drupal patches with git
Applying patches with git

If you are not using git, this command will also work:
patch -p1 < patch-file-name.patch

Let me know if that doesn't make sense.

I'm rejecting the patch because it results in an empty row in the DB.

We need it to remove the row if empty, otherwise we could end up with thousands of no-value rows in the DB which is simply wasteful and inefficient.

Good catch on the bug though, working on it now.

Fixed in dev with the following:

[nthompson@localhost page_title]$ git diff
diff --git a/page_title.module b/page_title.module
index 5d7367e..25c4086 100644
--- a/page_title.module
+++ b/page_title.module
@@ -402,8 +402,15 @@ function page_title_node_insert($node) {
  * Implement hook_node_update().
  */
 function page_title_node_update($node) {
-  if (user_access('set page title') && isset($node->page_title) && drupal_strlen(trim($node->page_title)) > 0) {
-    db_merge('page_title')->key(array('type' => 'node', 'id' => $node->nid))->fields(array('page_title' => $node->page_title))->execute();
+  if (user_access('set page title') && isset($node->page_title)) {
+    // If there is content to the Page Title, 'merge' it (ie, either UPDATE or INSERT)
+    if (drupal_strlen(trim($node->page_title)) > 0) {
+      db_merge('page_title')->key(array('type' => 'node', 'id' => $node->nid))->fields(array('page_title' => $node->page_title))->execute();
+    }
+    // Otherwise, delete the row (if there is one)
+    else {
+      db_delete('page_title')->condition('type', 'node')->condition('id', $node->nid)->execute();
+    }
   }
 }

Basically, if the "length > 0" then we do an UPDATE/INSERT SQL otherwise we just do a DELETE.