There seems to be some strange inserted text in the epublish_help function of the epublish.module about line 167. Something about India Times.

Also, inserting $output=""; at line 96 will avoid Drupal undefined variable errors, since the hook function is run on every page apparently.

Also, the "raquo" sequences need to be replaced with explicit "»" as Drupal doesn't interpret them, at least in my installation.

Attaching a corrected file.

CommentFileSizeAuthor
#4 epublish-1253732-3.patch4.25 KBleonardwestermeyer
#3 epublish-1253732-2.patch5.91 KBleonardwestermeyer
#2 epublish-1253732-1.patch1.73 KBleonardwestermeyer
epublish.zip22.09 KBleonardwestermeyer

Comments

leonardwestermeyer’s picture

leonardwestermeyer commented
Issue summary: View changes

Correcting message.

sdague’s picture

sdague commented

Could you provide this as a patch instead? (http://drupal.org/project/epublish/git-instructions). It is much easier to integrate it then.

leonardwestermeyer’s picture

leonardwestermeyer commented
Version: 6.x-1.12 » 6.x-1.13
StatusFileSize
new epublish-1253732-1.patch1.73 KB

Heres my first attempt at a patch to 6.x-1.13 to fix the first issue mentioned, that of the extraneous text in the help section of epublish.module.

leonardwestermeyer’s picture

leonardwestermeyer commented
StatusFileSize
new epublish-1253732-2.patch5.91 KB

Here's the second patch which takes care of the remaining problems. It wasn't necessary to substitute the "raquo" sequences, because the problem was that the l() function hadn't been updated to Drupal version 6, and was not showing the links correctly.

leonardwestermeyer’s picture

leonardwestermeyer commented
StatusFileSize
new epublish-1253732-3.patch4.25 KB

Here's a third patch which corrects additional instances of the use of Drupal Version 5.0 l() function. These are all in the epublish_layout_indexed.inc file.

sdague’s picture

sdague commented
Status: Active » Closed (fixed)

These patches look good. Applied them all to 6.x stream. Will be in 6.x-1.4.

leonardwestermeyer’s picture

leonardwestermeyer commented

You mean 6.x-1.14.....I suppose..

sdague’s picture

sdague commented

Yes, 1.14. :)

sdague’s picture

sdague commented
Issue summary: View changes

Correction.