Hi Kristen,
Not sure if these should be posted as seperate issues, but I'm presuming they are fairly minor!? I can separate if needs be.
I found these PHP Notices on 7.x-1.0-beta2 and also after upgrading to the latest dev when displaying a Feature Block on a node.
# Notice: Undefined variable: node in featured_content_sort_nodes_by_terms() (line 1554 of /var/www/drupal7.nuim.ie/sites/all/modules/featured_content/featured_content.module).
# Notice: Object of class stdClass could not be converted to int in featured_content_sort_nodes_by_terms() (line 1557 of /var/www/drupal7.nuim.ie/sites/all/modules/featured_content/featured_content.module).
It's quite a fresh install of Drupal 7.7, so I'm not sure what the best way of going about debugging is. If you have any suggestions I can take a look, or let me know what further info is required to help locate the issue.
Thank you,
mccrodp
Comments
Comment #1
snyderp commentedHere is a quick fix patch for this issue against head.
Kristen, if this looks good to you, should I apply? This would be my first commit to someone else's drupal project, so just want to make sure I'm not stepping on your toes :-)
Comment #2
kristen polI took a quick look and it seems fine... if you are able to test after applying and committing the patch, that would be great.
Thanks!
Kristen
Comment #3
snyderp commentedI've applied the path to head. Things should be good to go here!
Comment #4
snyderp commentedComment #5
ejnavav commentedHi Kristen/snyderp.
I just downloaded this module and I'm having the same error. Don't know how to solve it or if I'm doing something wrong.
Basically what I'm building is a jobs site and I want to display possible candidates that match the current job being viewed. and the other way around as well - Show possible jobs when viewing a candidate-.
I've noticed that I got this error when I set it so sort by 'Closest match to current page by terms'.
I'm a bit frustrated because I can only see comments from people being happy using it from its easy to setup/configure interface however, I cant get it to work if I sort it by date or any other sorting It just shows content sorted by that field but not related to the current node.
Comment #6
ejnavav commented??
Comment #7
kristen polHi ejnavav,
Did you try downloading the *dev* version?
Thanks,
Kristen
Comment #8
kristen polComment #9
carvalhar commentedi got these errors with dev version (and also checking manually the patch):
Notice: Undefined variable: nodes em featured_content_get_nodes() (linha 1911 de C:\xampp\htdocs\ite\sites\all\modules\featured_content\featured_content.module).I noticed this error comes from function featured_content_get_nodes because featured content was sorting by popularity.
But i couldn't resolve it. I think $nodes came empty from $result...
Comment #10
carvalhar commentedactive
Comment #11
kristen pol@carvalhar - please let me know what version of FC you are using.
Thanks,
Kristen
Comment #12
carvalhar commented7.x-1.x-dev
Comment #13
kristen polI just checked in the code that should fix it so it will be available in 7.x-1.x-dev once drupal.org runs its updates. Just look at the timestamp to be sure.
Kristen
Comment #14
kristen polI'll close this for now... please reopen if you are still having problems.
Kristen
Comment #15
quantos commentedFollowing. I have this problem with Drupal 7.12 and FC 7.x-1.5:
Notice: Undefined variable: nids in featured_content_block_view() (line 238 of C:\xampp\htdocs\D2\sites\all\modules\featured_content\featured_content.module).
Kristen: which version of Drupal core was it you thought should fix this; "I just checked in the code that should fix it so it will be available in 7.x-1.x-dev once drupal.org runs its updates", just so we know.
Thanks. Love the module btw.
Comment #16
kristen polHi @quantos. Can you please try the FC 7.x-1.x-dev version and see if it fixes your issue?
Thanks!
Kristen
Comment #17
solution33r commentedHi Kristen,
I created a patch for the D6 version of this module (6.x-1.5), based on the patch for 7.x-1.0-beta2. I have attached that to this update, hope it helps!